After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 437403 - gst-plugins-bad uses #ifdef G_OS_WIN32 instead of #ifdef _MSC_VER to use some #pragma
gst-plugins-bad uses #ifdef G_OS_WIN32 instead of #ifdef _MSC_VER to use some...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 0.10.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-05-10 10:11 UTC by Ali Sabil
Modified: 2007-06-05 11:32 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
Proposed patch (568 bytes, patch)
2007-05-10 10:12 UTC, Ali Sabil 		committed Details | Review

Description Ali Sabil 2007-05-10 10:11:53 UTC 
Please describe the problem:
the replaygain plugin makes use of #ifdef G_OS_WIN32 instead of #ifdef _MSC_VER to use some #pragma , and this breaks the compilation when using mingw32 to compile instead of the MS compiler.

Steps to reproduce:



Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Ali Sabil 2007-05-10 10:12:16 UTC 
Created attachment 87943 [details] [review]
Proposed patch
Comment 2 David Schleef 2007-05-13 19:58:09 UTC 
Yup, of course.  Applied.