After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 437260 - CFLAGS are poinsoned by the OpenGL test
CFLAGS are poinsoned by the OpenGL test
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-05-09 19:13 UTC by Ali Sabil
Modified: 2007-05-10 07:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed fix (595 bytes, patch)
2007-05-09 19:15 UTC, Ali Sabil 		none Details | Review

Description Ali Sabil 2007-05-09 19:13:18 UTC 
the current configure.ac doesn't save and restore and CFLAGS during the OpenGL test
Comment 1 Ali Sabil 2007-05-09 19:15:33 UTC 
Created attachment 87911 [details] [review]
Proposed fix
Comment 2 David Schleef 2007-05-09 21:19:32 UTC 
Why does CFLAGS need to be saved/restored if it's not modified?
Comment 3 Ali Sabil 2007-05-10 05:09:34 UTC 
In my case the CFLags needs to be saved and restored because, I am cross compiling, and for some reason a -I/usr/include end up appearing in the CFLAGS, and this breaks the compilation of gstmultifile.c, because it tries to include unistd.h which is not available in the target platform.

p.s. I am cross compiling usng mingw32 to generate windows binaries and libraries from Linux.
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2007-05-10 06:37:07 UTC 
I've applied it as it won't hurt and CPP/CXX flags are saved too and they are not modified in a obvious way.

2007-05-10  Stefan Kost  <ensonic@users.sf.net>

	Patch by: Ali Sabil <ali.sabil@gmail.com>

	* configure.ac:
	  Save and restore CFLAGS for OpenGL check. Fixes #437260.
Comment 5 Ali Sabil 2007-05-10 06:46:27 UTC 
Actually I just found out that there is still a problem with my patch, the CFLAGS needs to be saved before AG_GST_CHECK_X otherwise the saving is useless
Comment 6 Stefan Sauer (gstreamer, gtkdoc dev) 2007-05-10 07:41:50 UTC 
stupid me, the CPPFLAGS and LIBS are obviously changed. I reverted the patch and fixed the CFLAGS thing in the AG_GST_CHECK_X macro.