After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 437212 - gnome-db-entry-password uses openssl to generate md5 hash
gnome-db-entry-password uses openssl to generate md5 hash
Status: RESOLVED FIXED
Product: libgnomedb
Classification: Deprecated
Component: widgets
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: malerba
gnome-db Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-05-09 16:41 UTC by Gustavo R. Montesino
Modified: 2007-05-17 10:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Untested patch to use libgcrypt insteado of openssl (3.45 KB, patch)
2007-05-09 16:45 UTC, Gustavo R. Montesino
none Details | Review

Description Gustavo R. Montesino 2007-05-09 16:41:50 UTC
The gnome-db-entry-password uses the openssl crypto library to generate the md5 hash of the password. Unfortunately, openssl's license isn't compatible with the GPL; so any GPL application linked against libgnomedb might have to add an openssl exemption clause to its license (not sure if it would be needed due only to an indirect link, but it would certainly be needed if the application ends directly linked against openssl).

I'm attaching a patch (untested) to use the LGPLed libgcrypt instead.
Comment 1 Gustavo R. Montesino 2007-05-09 16:45:29 UTC
Created attachment 87894 [details] [review]
Untested patch to use libgcrypt insteado of openssl
Comment 2 malerba 2007-05-10 07:49:11 UTC
What about when the crypto library is not installed, should we compile against openssl (which does not seem to be a good solution because of the license problem), or should we just disable building the gnome-db-entry-password plugin?
Comment 3 Gustavo R. Montesino 2007-05-10 09:36:09 UTC
IMHO, libgcrypt is lightweight enough to be considered an obligatory dependency. (ie, fail the configure if it isn't available). Another option would be to disable the md5 stuff and just return a null gvalue.
Comment 4 malerba 2007-05-16 22:21:27 UTC
Correction committed to SVN, the plugin is now built only if the libgcrypt library is present. If you think it's OK, I'll close the bug.
Comment 5 Gustavo R. Montesino 2007-05-17 03:18:26 UTC
That's great for me; feel free to close the bug. Thanks for the great work.
Comment 6 malerba 2007-05-17 10:22:23 UTC
Thanks!