After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 436818 - replace gnome_help_display
replace gnome_help_display
Status: RESOLVED FIXED
Product: gnome-screensaver
Classification: Deprecated
Component: dialog
2.19.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-screensaver maintainers
gnome-screensaver maintainers
Depends on:
Blocks:
 
 
Reported: 2007-05-08 09:30 UTC by Jani Monoses
Modified: 2007-07-05 20:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
the patch (2.07 KB, patch)
2007-05-08 09:31 UTC, Jani Monoses
none Details | Review
updated patch (2.34 KB, patch)
2007-06-22 07:58 UTC, Jani Monoses
committed Details | Review

Description Jani Monoses 2007-05-08 09:30:36 UTC
This lessens the dependence on libgnomeui by replacing gnome_help_display_desktop() with the equivalent call from libgnome. A similar patch has been sent to g-power-manager, and one recently committed to evince trunk.
The only other dep on libgnomeui is calling gnome_program_init(). If that were replaced by gtk_init() bug-buddy support would no longer be activated in the gss-preferences app.
Comment 1 Jani Monoses 2007-05-08 09:31:17 UTC
Created attachment 87789 [details] [review]
the patch
Comment 2 Jani Monoses 2007-06-22 07:58:16 UTC
Created attachment 90437 [details] [review]
updated patch

pop up a dialog if gnome-open could not be executed
Comment 3 William Jon McCann 2007-07-05 20:59:48 UTC
Committed to trunk with a few minor fixes for indentation and spacing.  Thanks.