After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 436699 - N'Ko support
N'Ko support
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
1.16.x
Other All
: Normal enhancement
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2007-05-07 20:45 UTC by Eugeniy Meshcheryakov
Modified: 2007-05-23 02:00 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
patch for N'Ko support in pango (20.71 KB, patch)
2007-05-07 20:49 UTC, Eugeniy Meshcheryakov
none Details | Review
updated patch (2.75 KB, patch)
2007-05-15 22:10 UTC, Eugeniy Meshcheryakov
committed Details | Review
Sample text in N'Ko (1.75 KB, text/plain)
2007-05-19 20:44 UTC, Eugeniy Meshcheryakov
  Details
Rendering of sample text (64.58 KB, image/png)
2007-05-19 20:46 UTC, Eugeniy Meshcheryakov
  Details

Description Eugeniy Meshcheryakov 2007-05-07 20:45:56 UTC
Please add support for N'Ko writting system.
Comment 1 Eugeniy Meshcheryakov 2007-05-07 20:49:40 UTC
Created attachment 87747 [details] [review]
patch for N'Ko support in pango

This patch adds support for N'Ko opentype shaping. Needed glyphs were added in Unicode 5.0. Patch is based on Unicode data files, "Proposal to add the N'Ko script to the BMP of the UCS" and Syriac shaping module.
Comment 2 Behdad Esfahbod 2007-05-07 20:54:14 UTC
Thanks.  Do you have any fonts to test this?
Comment 3 Eugeniy Meshcheryakov 2007-05-07 21:04:48 UTC
(In reply to comment #2)
> Thanks.  Do you have any fonts to test this?
> 

I'm working on N'Ko support in DejaVu, there are only several glyphs done, it is available in nko branch in the repository (http://dejavu.svn.sourceforge.net/svnroot/dejavu/branches/nko). I can provide ttf if needed. You can also test shaping with non-free Code2000, but it does not have anchors for combining marks. I do not know about other opentype fonts that support N'Ko.
Comment 4 Behdad Esfahbod 2007-05-15 20:49:41 UTC
I have drastically simplified arabic-fc.c.  Can you update your patch?

At some point I want to merge arabic, syriac, and n'ko modules.  But maybe we should simply add n'ko to the current arabic module?  It's just a matter of adding the joining table.  The rest of the code is the same, right?  (as opposed to syriac which has a couple more joining rules).
Comment 5 Eugeniy Meshcheryakov 2007-05-15 22:10:36 UTC
Created attachment 88251 [details] [review]
updated patch

Here is updated patch for N'Ko support, it is unified with arabic module.
Comment 6 Behdad Esfahbod 2007-05-15 22:12:56 UTC
Looks a lot simpler.  Thanks!

I'll go on and commit this tonight.
Comment 7 Behdad Esfahbod 2007-05-15 23:09:39 UTC
I modified your arabic-fc.c changes to just add the N'Ko script to the current engine instead of listing two engines (which were creating the same engine object anyway).

2007-05-15  Behdad Esfahbod  <behdad@gnome.org>

        Bug 436699 – N'Ko support
        Patch by Eugeniy Meshcheryakov

        * modules/arabic/arabic-fc.c (create):
        * modules/arabic/arabic-ot.c (Get_Joining_Class):
        Add N'Ko support to the Arabic module.

Comment 8 Behdad Esfahbod 2007-05-16 16:36:19 UTC
Eugeniy, can you attach screenshots of Pango rendering N'Ko?
Also, can you provide a sample text to put in pango/pango-view/test-nko.txt?  Something having a few short lines, preferably a notable text or poem, etc.

Thanks,
Comment 9 Nicolas Spalinger 2007-05-17 23:34:58 UTC

(In reply to comment #3)
> (In reply to comment #2)
> > Thanks.  Do you have any fonts to test this?
> > 
> 
> I'm working on N'Ko support in DejaVu, there are only several glyphs done, it
> is available in nko branch in the repository
> (http://dejavu.svn.sourceforge.net/svnroot/dejavu/branches/nko). I can provide
> ttf if needed. You can also test shaping with non-free Code2000, but it does
> not have anchors for combining marks. I do not know about other opentype fonts
> that support N'Ko.


There's another N'Ko smart font project based on the Koli N'ko Manden font developed by Mamady Doumboya here:
http://scripts.sil.org/GraphiteFonts

It uses Graphite and only the GDL code is modifiable, but it might be useful for testing.
Comment 10 Eugeniy Meshcheryakov 2007-05-19 20:44:09 UTC
Created attachment 88454 [details]
Sample text in N'Ko

Here is begining of "Casablanca Statement" (may contain errors) from http://www.panafril10n.org/panafrloc/ . That is the only thext in N'Ko with more than several words I found.
Comment 11 Eugeniy Meshcheryakov 2007-05-19 20:46:23 UTC
Created attachment 88455 [details]
Rendering of sample text

Here is rendering of sample text in png format generated by pangoview-cairo. Font used is available at http://people.debian.org/~eugen/dejavu/nko/.
Comment 12 Eugeniy Meshcheryakov 2007-05-19 20:47:54 UTC
> Here is rendering of sample text in png format generated by pangoview-cairo.

That was pangocairo-view
Comment 13 Behdad Esfahbod 2007-05-23 02:00:47 UTC
2007-05-22  Behdad Esfahbod  <behdad@gnome.org>

        * pango-view/Makefile.am:
        * pango-view/test-nko.txt:
        New test text for N'Ko.