After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 435973 - Migrating from GnomeAbout to GtkAboutDialog
Migrating from GnomeAbout to GtkAboutDialog
Status: RESOLVED FIXED
Product: gok
Classification: Deprecated
Component: general
1.2.x
Other Linux
: Normal normal
: ---
Assigned To: David Bolter
David Bolter
Depends on:
Blocks:
 
 
Reported: 2007-05-04 21:44 UTC by Christian Kirbach
Modified: 2009-02-12 10:53 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
Migrating from GnomeAbout to GtkAboutDialog (1.48 KB, patch)
2007-05-04 21:44 UTC, Christian Kirbach 		reviewed Details | Review
Migrating from GnomeAbout to GtkAboutDialog (3.05 KB, patch)
2007-05-05 13:57 UTC, Christian Kirbach 		none Details | Review
Updated patch that uses gtk_show_about_dialog which handles signals (and screen) automatically. (3.21 KB, patch)
2008-07-17 07:51 UTC, Gerd Kohlberger 		committed Details | Review

Description Christian Kirbach 2007-05-04 21:44:00 UTC 
Since version 2.6, GTK+ provides the GtkAboutDialog widget as a replacement for the GnomeAbout dialog in the libgnomeui library.
Comment 1 Christian Kirbach 2007-05-04 21:44:32 UTC 
Created attachment 87573 [details] [review]
Migrating from GnomeAbout to GtkAboutDialog
Comment 2 David Bolter 2007-05-05 12:13:05 UTC 
Comment on attachment 87573 [details] [review]
Migrating from GnomeAbout to GtkAboutDialog

Thanks Christian, could you change 2003 to 2007 in both places below? After that change please go ahead and commit. Great to have your help on GOK!

>+		"copyright", "Copyright (C) 2001-2003 Sun Microsystems, Copyright (C) 2001-2003 University of Toronto",
Comment 3 Christian Kirbach 2007-05-05 13:56:20 UTC 
David, please test the patch, I could not test it yet (missing assistive tech stuff)

While digging deeper into this I found out that

 "translator-credits", strcmp (translator_credits, "translator_credits") != 0 ? translator_credits : NULL,

was (a) unneccessary

http://developer.gnome.org/doc/API/2.0/gtk/GtkAboutDialog.html#gtk-about-dialog-set-translator-credits

and (b) wrong, since translator_credits is initialised as "translator-credits" (with a dash, not underscore)


Also, we can easily get rid of all the gdkpixbuf stuff since gtkabout takes care of this.
I presume we can also emit the about dialog hack, please test.
Comment 4 Christian Kirbach 2007-05-05 13:57:14 UTC 
Created attachment 87602 [details] [review]
Migrating from GnomeAbout to GtkAboutDialog
Comment 5 Gerd Kohlberger 2008-07-17 07:47:01 UTC 
Christian, David, I've tested the patch and found a few problems. The close button and delete-events aren't handled and some properties are missing.
Comment 6 Gerd Kohlberger 2008-07-17 07:51:04 UTC 
Created attachment 114704 [details] [review]
Updated patch that uses gtk_show_about_dialog which handles signals (and screen) automatically.
Comment 7 Gerd Kohlberger 2008-07-28 08:51:22 UTC 
Committed to trunk.
Comment 8 André Klapper 2009-02-10 22:59:24 UTC 
The commit was reverted by http://svn.gnome.org/viewvc/gok/trunk/gok/gok-keyboard.c?r1=2518&r2=2519 , hence reopening.

PLEASE get this in quickly before it's STRING FREEZE again on Monday!!
(String changes must be announced to gnome-18n@)
Comment 9 Gerd Kohlberger 2009-02-11 08:55:10 UTC 
Committed to trunk. (again :))
Comment 10 Christian Kirbach 2009-02-11 23:59:50 UTC 
Thank God you spotted this Andre
Comment 11 André Klapper 2009-02-12 10:53:33 UTC 
I do thank him at least once per day, but mostly for other things ;-)