After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 435747 - tag button should be a toggle button
tag button should be a toggle button
Status: RESOLVED OBSOLETE
Product: tomboy
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Tomboy Maintainers
Tomboy Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-05-04 08:01 UTC by David Prieto
Modified: 2008-02-26 20:51 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
proposed patch (1.75 KB, patch)
2007-05-13 13:42 UTC, Everaldo Canuto 		needs-work Details | Review

Description David Prieto 2007-05-04 08:01:51 UTC 
Please describe the problem:
the new tag button in Tomboy acts as a toggle button: clicking it once shows the tabs, clicking it again hides them. Therefore, it should look as one too. This would also allow to remove the "close" button and save some precious space.

This is how a note showing its tags looks now: http://img502.imageshack.us/img502/3895/tagsfq3.png

And this is how it should look like: http://img209.imageshack.us/img209/2322/tags2lw9.png

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Boyd Timothy 2007-05-04 13:13:53 UTC 
Thanks for the suggestion.  I agree, it ought to be this way.
Comment 2 Everaldo Canuto 2007-05-13 13:42:47 UTC 
Created attachment 88118 [details] [review]
proposed patch

Attached a patch to change actual tags_button to ToggleToolButton type, also some other changes to deactivate it when tagbar is closed.
Comment 3 Boyd Timothy 2007-05-14 15:35:40 UTC 
After applying this patch, I get the following:

(Tomboy:5041): Gtk-WARNING **: Mixing deprecated and non-deprecated GtkToolbar API is not allowed

(Tomboy:5041): Gtk-WARNING **: gtkwidget.c:3425: widget `GtkToggleToolButton' has no activatable signal "activate" without arguments

Additionally, the Ctrl+T hotkey doesn't work to open/close the tag bar.
Comment 4 Sandy Armstrong 2008-01-13 15:01:54 UTC 
No tagging UI anymore.  :-)