After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 435577 - [pending]Orca does not speak labels of embedded components in gnome-panel
[pending]Orca does not speak labels of embedded components in gnome-panel
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
2.19.x
Other All
: Normal normal
: ---
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-05-03 17:44 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2007-05-08 21:35 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
patch to hopefully solve the reported problem (3.38 KB, patch)
2007-05-03 17:50 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review
refinement for better access (1.25 KB, patch)
2007-05-03 21:36 UTC, Joanmarie Diggs (IRC: joanie)
none Details | Review
we should probably explicitly check that the "focused" panel really isn't (1.33 KB, patch)
2007-05-03 22:06 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2007-05-03 17:44:34 UTC
Certain applets in gnome-panel display labels (e.g. CPU Frequency Monitor, GNOME Weather).  Orca does not speak those labels when one navigates to them.
Comment 1 Joanmarie Diggs (IRC: joanie) 2007-05-03 17:50:06 UTC
Created attachment 87474 [details] [review]
patch to hopefully solve the reported problem

If there's a label being displayed, this patch should cause it to be spoken.

Note that with the CPU Frequency Monitor, we do not always seem to be getting updated information.  Some tickling/poking/slapping/taunting of the hierarchy in gnome-panel.py might do the trick.  Dunno yet.  I'll look at that next.

BTW, the reason I made potentialLabel a list is because the CPU Frequency Monitor has two labels: number and units.
Comment 2 Joanmarie Diggs (IRC: joanie) 2007-05-03 19:47:01 UTC
Just checked the patch in.  Updating the summary to pending.
Comment 3 Joanmarie Diggs (IRC: joanie) 2007-05-03 21:36:53 UTC
Created attachment 87495 [details] [review]
refinement for better access

Another issue with gnome-panel is that panels keep issuing their own focused events (with detail1==1) when they're not actually focused.  It's as if they want to claim credit for being the parent of the thing that actually has focus.  The minor problem with this is that we say "panel" more than we should.  The more significant problem is that we display "panel" in braille rather than continuing to display the thing that actually has focus.  This patch handles this.

Thoughts?
Comment 4 Joanmarie Diggs (IRC: joanie) 2007-05-03 22:06:43 UTC
Created attachment 87498 [details] [review]
we should probably explicitly check that the "focused" panel really isn't

We should explicitly check to be sure the panel which is claiming to have focus really doesn't have focus before we dismiss it. :-)
Comment 5 Joanmarie Diggs (IRC: joanie) 2007-05-08 20:20:34 UTC
Any problems with this latest version (which stops saying and displaying "panel" unnecessarily)?  If not I'll check it in and close this out. :-)
Comment 6 Willie Walker 2007-05-08 21:24:49 UTC
Looks food to me.  Thanks!
Comment 7 Joanmarie Diggs (IRC: joanie) 2007-05-08 21:35:18 UTC
> Looks food to me.  Thanks!

Hungry? ;-)

Patch committed.  Closing as FIXED.  Thanks!