After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 435003 - Unsafe Message-ID with hostname, without FQDN
Unsafe Message-ID with hostname, without FQDN
Status: RESOLVED OBSOLETE
Product: balsa
Classification: Other
Component: general
2.3.x
Other Linux
: Normal normal
: ---
Assigned To: Balsa Maintainers
Balsa Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-05-01 20:50 UTC by Sven Arvidsson
Modified: 2021-06-01 22:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Debugging patch. (645 bytes, patch)
2007-05-05 08:20 UTC, Pawel Salek
none Details | Review

Description Sven Arvidsson 2007-05-01 20:50:34 UTC
[ Forwarded from http://bugs.debian.org/421459 ]

"Balsa does not use the FQDN for Message-IDs, which means no guarantee, that
an ID exists only once.

I have checked, wether there is any problem on the system (freshly installed
Debian Etch Stable), which could cause this behaviour,

#v+
hajo@Odysseus:~$ hostname
Odysseus
hajo@Odysseus:~$ hostname -d
Zierke.com
hajo@Odysseus:~$ hostname -f
Odysseus.Zierke.com
hajo@Odysseus:~$ dnsdomainname
Zierke.com
hajo@Odysseus:~$ cat /etc/mailname
Zierke.com
#v-

but don't find anything."
Comment 1 Pawel Salek 2007-05-05 07:36:17 UTC
Is it a build with our without libsmtp?
Comment 2 Pawel Salek 2007-05-05 08:20:35 UTC
Created attachment 87592 [details] [review]
Debugging patch.

This patch may aid the debugging of the problem. Balsa tries hard to determine the domain name but it could be it falls back to a host-only code...
Comment 3 Sven Arvidsson 2007-05-06 21:37:09 UTC
The Debian build seems to use libesmtp5 1.0.3.

Comment 4 Hans-Joachim Zierke 2007-05-10 06:36:13 UTC
I don't understand, what the patch is supposed to do. All that I get, is a
message: "Using fallback host name: Odysseus", but I already knew that.

Plus: If Balsa can't issue a "hostname -f", correct behaviour would be, to leave the job to the MTA, instead of creating unsafe Message-IDs.


Ciao
Hans-Joachim
Comment 5 Pawel Salek 2007-05-10 07:34:14 UTC
This may be wording issue but there is nothing "unsafe" about generating msg-ids that do not contain domain name. RFC2822 RECOMMENDs that - sinceit is a reasonable method of avoiding clashes between msg-ids. 

Re the patch, it says that your compiler does not define _GNU_SOURCE causing the fallback code to be compiled - and it raises a question, why this isn't the case? A solution is to do a configure-time test for gnu libc and define this constant on or own, but of course this will not solve the real problem if you are *not* using GNU libc...
If GNU libc is not used and uname() cannot provide domain name, we could always call getdomainname() explicitly...
Comment 6 André Klapper 2021-06-01 22:42:55 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new enhancement request ticket at
  https://gitlab.gnome.org/GNOME/balsa/-/issues/

Thank you for your understanding and your help.