After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 434956 - themus-theme-applier.desktop should use Hidden=True
themus-theme-applier.desktop should use Hidden=True
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] theme-manager
2.19.x
Other Linux
: Normal minor
: ---
Assigned To: Thomas Wood
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-05-01 18:10 UTC by Vincent Untz
Modified: 2007-11-23 16:33 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20

Attachments
using ShowOnlyIn=; does the trick (436 bytes, patch)
2007-05-19 13:13 UTC, Sebastien Bacher 		committed Details | Review
fix .desktop validation (553 bytes, patch)
2007-11-22 14:52 UTC, Frederic Crozat 		committed Details | Review

Description Vincent Untz 2007-05-01 18:10:32 UTC 
It currently uses NoDisplay=True, but that's not enough: NoDisplay means it's not displayed by default in the menu, but the user can see it in the menu editor and display it. Hidden means the menu system won't even look at the file.
Comment 1 Vincent Untz 2007-05-01 18:18:18 UTC 
Hrm, that's not enough. I'll reopen the bug once I figure out the right way to do this (might need a change in the fdo specs).
Comment 2 Sebastien Bacher 2007-05-19 13:13:09 UTC 
Created attachment 88441 [details] [review]
using ShowOnlyIn=; does the trick
Comment 3 Sebastien Bacher 2007-05-19 13:14:29 UTC 
I've commited the change to trunk
Comment 4 Frederic Crozat 2007-11-22 14:52:30 UTC 
Created attachment 99479 [details] [review]
fix .desktop validation

previous patch broke validation with latest desktop-file-validate (because empty list is not explicitly permitted by spec, I've opened a clarification bug request at https://bugs.freedesktop.org/show_bug.cgi?id=13345 )

Attached patch uses a new desktop keyword which is known to not exist :)
Comment 5 Jens Granseuer 2007-11-22 18:35:18 UTC 
Oh, the joys of snaking your way around standards. Go ahead. Thanks.
Comment 6 Frederic Crozat 2007-11-23 16:33:20 UTC 
committed on trunk :

2007-11-23  Frederic Crozat  <fcrozat@mandriva.com>

        * themus-theme-applier.desktop.in.in: Fix .desktop to be valid (bug
        #434956)