After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 434784 - should not call glib-mkenums from Makefile.am directly
should not call glib-mkenums from Makefile.am directly
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: build
git master
Other All
: Normal normal
: ---
Assigned To: Li Yuan
Li Yuan
Depends on:
Blocks:
 
 
Reported: 2007-05-01 04:54 UTC by Brian Cameron
Modified: 2007-05-11 05:51 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
patch fixing the problem (1.10 KB, patch)
2007-05-01 04:54 UTC, Brian Cameron
accepted-commit_now Details | Review

Description Brian Cameron 2007-05-01 04:54:25 UTC
So ATK can build when using uninstalled.pc files, the configure script calls AM_PATH_GLIB_2_0, which sets $(GLIB_MKENUMS).  If compiling against glib's uninstalled.pc file, this variable gets set with the right path and the code can be compiled.  Without this patch the make fails because it can't find glib-mkenums directly.

This patch changes the Makefile.am to use $(GLIB_MKENUMS) so the code can be compiled.
Comment 1 Brian Cameron 2007-05-01 04:54:54 UTC
Created attachment 87304 [details] [review]
patch fixing the problem
Comment 2 Brian Cameron 2007-05-10 05:31:25 UTC
Can this go upstream?
Comment 3 Li Yuan 2007-05-10 06:50:10 UTC
Thanks for the patch. Please commit into trunk and 2.18 branch. 
Comment 4 Brian Cameron 2007-05-11 05:51:43 UTC
Fixed in SVN head.  I don't personally need this in the 2.18 branch, so I didn't apply there.