GNOME Bugzilla – Bug 434591
Add pkgconfig file to locate where new keybindings should be installed
Last modified: 2007-05-02 13:18:22 UTC
Right now, there's no easy way for 3rd-party packages to know where to install additional keybindings. This patch should fix it. It was requested by Dave Reveman for compiz, I'm sure it would be useful for others.
Created attachment 87267 [details] [review] control-center-pkgconfig-for-keybindings.patch
Created attachment 87268 [details] [review] control-center-pkgconfig-for-keybindings-2.patch Forgot to update the extra_dist and the targets properly
Created attachment 87269 [details] [review] gnome-launch-box-use-custom-keybindings.patch An example patch for gnome-launch-box to use the new custom keybindings.
Looks good, please commit.
2007-04-30 Bastien Nocera <hadess@hadess.net> * configure.in: Generate a capplets/keybindings/gnome-keybindings.pc from the .in file 2007-04-30 Bastien Nocera <hadess@hadess.net> * Makefile.am: upd * gnome-keybindings.pc.in: add a noarch pkgconfig file to allow applications to know where to add their keybindings (Closes: #434591)
+AM_PROG_CC_C_O That looks unrelated... +prefix=@prefix@ +pkgdatadir=@datadir@/@GETTEXT_PACKAGE@ +keysdir=${pkgdatadir}/keybindings I'm sorry, but this is completely wrong. You need something like this: prefix=@prefix@ datarootdir=@datarootdir@ datadir=@datadir@ pkgdatadir=${datadir}/@PACKAGE@ keysdir=${pkgdatadir}/keybindings since capplets/keybindings/Makefile.am defines the directory to that.
(In reply to comment #6) > +AM_PROG_CC_C_O > > That looks unrelated... It is, but was necessary for compilation with more recent versions of automake. > +prefix=@prefix@ > +pkgdatadir=@datadir@/@GETTEXT_PACKAGE@ > +keysdir=${pkgdatadir}/keybindings > > I'm sorry, but this is completely wrong. You need something like this: > > prefix=@prefix@ > datarootdir=@datarootdir@ > datadir=@datadir@ > pkgdatadir=${datadir}/@PACKAGE@ > keysdir=${pkgdatadir}/keybindings > > since capplets/keybindings/Makefile.am defines the directory to that. You're right. I fixed it in SVN. Thanks for the eagle-eyed review :) 2007-05-02 Bastien Nocera <hadess@hadess.net> * gnome-keybindings.pc.in: Fix keysdir substitution, as reported by Christian Persch <chpe@svn.gnome.org> (Closes: #434591)