Bug 433703 – [Patch] Run gtk-update-icon-cache in install-hook and uninstall-hook

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 433703 - [Patch] Run gtk-update-icon-cache in install-hook and uninstall-hook


Summary:	[Patch] Run gtk-update-icon-cache in install-hook and uninstall-hook


Status:	RESOLVED FIXED

Product:	vino
Classification:	Applications
Component:	Preferences Dialog
Version:	2.18.x
Hardware:	Other All

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Vino Maintainer(s)
QA Contact:	Vino Maintainer(s)

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2007-04-26 20:48 UTC by David Farning
Modified:	2007-05-02 18:43 UTC

See Also:
GNOME target:	---
GNOME version:	2.17/2.18

Attachments
patch to run gtk-update-icon-cache in install-hook and uninstall-hook (1.15 KB, patch) 2007-04-26 20:51 UTC, David Farning	committed	Details \| Review

Description David Farning 2007-04-26 20:48:46 UTC

Please describe the problem:
In the theme-friendly-icons gnome goal:

  http://live.gnome.org/GnomeGoals/AppIcon

We made all apps run gtk-update-icon-cache in install-hook.  They also should
call it in uninstall-hook. Refer to #362604.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:

Comment 1 David Farning 2007-04-26 20:51:15 UTC

Created attachment 87098 [details] [review]
patch to run gtk-update-icon-cache in install-hook and uninstall-hook

Comment 2 David Farning 2007-04-26 22:16:44 UTC

Comment on attachment 87098 [details] [review]
patch to run gtk-update-icon-cache in install-hook and uninstall-hook

>Index: ChangeLog
>===================================================================
>--- ChangeLog	(revision 591)
>+++ ChangeLog	(working copy)
>@@ -1,3 +1,8 @@
>+2007-04-26  David Farning  <dfarning@gmail.com>
>+
>+	* icons/Makefile.am (update-icon-cache): fix gtk-update-icon-cache
>+	for install-hook and uninstall-hook.
>+
> 2007-04-23  Jonh Wendell  <jwendell@gnome.org>
> 
> 	* server/vino-input.c:
>Index: icons/Makefile.am
>===================================================================
>--- icons/Makefile.am	(revision 591)
>+++ icons/Makefile.am	(working copy)
>@@ -1,4 +1,14 @@
> iconsdir   = $(datadir)/icons/hicolor/48x48/apps
> icons_DATA = gnome-remote-desktop.png
>-
>+gtk_update_icon_cache = gtk-update-icon-cache -f -t $(datadir)/icons/hicolor
>+install-data-hook: update-icon-cache
>+uninstall-hook: update-icon-cache
>+update-icon-cache:
>+        @-if test -z "$(DESTDIR)"; then \
>+                echo "Updating Gtk icon cache."; \
>+                $(gtk_update_icon_cache); \
>+        else \
>+                echo "*** Icon cache not updated.  After (un)install, run this:"; \
>+                echo "***   $(gtk_update_icon_cache)"; \
>+        fi
> EXTRA_DIST = $(icons_DATA)

Comment 3 Jonh Wendell 2007-05-02 18:43:30 UTC

Thanks, patch commited in svn.