GNOME Bugzilla – Bug 433435
several changes to tree.py, dump.py, and sniff
Last modified: 2007-05-03 16:34:40 UTC
mostly to get more useful stuff like Relations and States in dump output and also sniff.
Created attachment 87035 [details] [review] patch to sniff.glade for new UI elements added 2 new lines to the table for States & Relations. Also changed default table packing options so it remains the same height when resizing window (but of course you can resize the table by hand)
Created attachment 87036 [details] [review] patch to dogtail/sniff/sniff file added functionality for new elements. Also includes patch for bug 432999.
Created attachment 87037 [details] [review] patch to dogtail/dump.py - changes spacer to 4 spaces - prints Actions, StateSet, Labellee, Labeller, Extents, parent name + index in parent, and Relations some might be more useful than others.
Created attachment 87038 [details] [review] patch to dogtail/tree.py - adds 2 lists: all States and Relations as defined in atspi - changes rawClick(button) to rawClick(button,x,y) x,y can be either relative or absolute (i found this really useful), its fully backward compatible :) - fixes a minor bug in "deselect" method - comments out hyperlink processing when generating children list (hyperlink handling is broken somewhere in lower layers) - adds "stateString" and "relationString" properties (used by both dump.py and sniff) - adds checking for any State or Relation using a schema "s_*" or "r_*" where * must be any string from rel_types or state_types striped of its SPI_STATE_ or SPI_RELATION_ substring - small change to one search method to return an empty list instead of None
This bug (and the attached patches) actually cover somewhere between 5 and 12 different issues (it's hard to tell immediately). In order for me to review them, they have to be separated. That means: - Each bug should deal with one issue only - Each patch should deal with one issue only - and preferably the whole issue. If multiple files need to be changed to correct an issue, put all that in the same patch, *except* if there is a new file. Attach new files separately. And to keep everything nice and self-contained, also add a ChangeLog entry in each patch. A good reference for all this is at: http://live.gnome.org/GnomeLove/SubmittingPatches and most of that is true for more than just GNOME. Don't be discouraged by this; once you get into the habit, it makes things easier. Thanks for your help! :)
ok I will submit separate bugs.