GNOME Bugzilla – Bug 433412
Note sync should handle "pinned" state
Last modified: 2017-07-31 12:40:46 UTC
In bug 305118 a discussion was started regarding the implemenation of note pinning. When a note is pinned it is now added to a whitespace-separated list of note URIs stored in GConf. The idea was to move away from GConf and store the pinning state in the note's xml instead. Changing that would bring benefits for note synchronization and drawbacks for compatibility. I will attach some code extracted from the patches of bug 305118 in a little while.
This is worth discussing. The question is basically whether being pinned is a property of a note (and therefore should be stored in the XML, and synchronized, etc) or if it is more like a preference.
Setting the default assignee and QA Contact to "tomboy-maint@gnome.bugs".
This bug is over a year old. I'd argue that this is a local preference of the current user. I might want to share my notes with my brother or my work laptop. I'll almost certainly won't pin the same notes on my private machine and the work box. My brother wouldn't want to have my notes pinned just as certainly. I'm heavily leaning towards pinning is local, notes might be global. Please don't mix these things.
What we *could* do is add the ability to sync the pinned state in our note synchronization infrastructure. I think that could be very useful, given the intended purpose of sync (one user, multiple machines). I agree with Benjamin that this shouldn't be part of the note XML. Given secret master plans, targetting for next cycle.
In the Tomboy Web sync backend, pinned state is synchronized. I'm not sure if it would be worth the effort to update the file-based sync backends to have this feature. In the future, when we support note sharing, we'll have to make sure that the pinned state is a per-user preference.
(In reply to comment #5) > In the Tomboy Web sync backend, pinned state is synchronized. This is not actually true. In the web sync backend, we sync pinned state *to* the server, but we do not sync it *from* the server.
So to sum up: 1) I have no intention of storing the pinned state in the XML. 2) I have every intention of making two-way sync of pinned state a feature in Tomboy 1.4. I wish I'd realized earlier it was not two-way so I could have fixed it for 1.2. It won't go in a point release to 1.2 because it will require some non-trivial changes to the sync code.
Thinking about this, I have different notes pinned at work and at home. I think that it should be possible to turn off the synchronization of the pinned state.
Great point, Stefan. It's kind of related to the idea of being able to sync only a subset of your notes.
The Tomboy team has moved from GNOME Bugzilla to GitHub for bug reports and feature requests: https://github.com/tomboy-notes/tomboy/issues/ Closing this report as NOTGNOME as part of Bugzilla Housekeeping (bug 781054) to keep tasks in one place. Please feel free to transfer this task to GitHub if this task is still valid in a recent Tomboy version. We are sorry for the inconvenience.