After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 433135 - [wavparse] regression in CVS with mp3-in-wav
[wavparse] regression in CVS with mp3-in-wav
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal blocker
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 433119
 
 
Reported: 2007-04-24 23:02 UTC by Tim-Philipp Müller
Modified: 2007-04-25 06:53 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Tim-Philipp Müller 2007-04-24 23:02:32 UTC
+++ This bug was initially created as a clone of Bug #433119 +++

Take the mp3-in-wav file attached in the above bug.

This now errors out with:

gstwavparse.c(1319): gst_wavparse_stream_headers (): /pipeline0/decodebin0/wavparse0:
Stream claims blockalign = 1, which is more than 0 - invalid data


It used to play with gstwavparse.c Revision 1.142.

(even though it puts timestamps on the buffers, despite the fix from bug #405213).
Comment 1 dynamotwain 2007-04-25 00:59:17 UTC
Straight from the Microsoft documentation, when the Audio Format 16-bit value isn't 1 (which signifies PCM audio), the SampleRate, ByteRate, BlockAlign, and BitsPerSample are all format specific and do not follow the same constraints that normal computation that one might make for PCM formats.

The only restriction I see that still applies for non-PCM data on BlockAlign is that "software must process a multiple of blockalign bytes at a time". In any case, a blockalign less than 1 makes no sense at all.

Perhaps these assertions should be wrapped in an if block checking if the waveform actually contains regular PCM data first?
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2007-04-25 06:53:31 UTC
2007-04-25  Stefan Kost  <ensonic@users.sf.net>

	* gst/wavparse/gstwavparse.c: (gst_wavparse_stream_headers):
	  Make header field check conditional. Fixes #433135