After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 433084 - Crash with unsupported Evolution addressbook URI
Crash with unsupported Evolution addressbook URI
Status: RESOLVED FIXED
Product: nautilus-sendto
Classification: Applications
Component: general
0.10
Other All
: Normal critical
: ---
Assigned To: Roberto Majadas
Roberto Majadas
: 441447 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-04-24 20:23 UTC by Øystein Gisnås
Modified: 2007-08-14 10:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix for the GError resetting bug (1.42 KB, patch)
2007-04-24 20:25 UTC, Øystein Gisnås 		none Details | Review
Patch from Debian (1.28 KB, patch)
2007-08-13 19:56 UTC, Øystein Gisnås 		accepted-commit_now Details | Review
Patch against trunk (1.33 KB, patch)
2007-08-13 21:18 UTC, Øystein Gisnås 		committed Details | Review

Description Øystein Gisnås 2007-04-24 20:23:18 UTC 
Steps to reproduce:
"If I rightclick a file within nautilus to send it, click on "send to"
and nautilus-sendto crashes. There is a backtrace attached." Reported by Michael Schmitt <mschmitt@unixkiste.org> at http://bugs.debian.org/415491

The reporter had scalix addressbooks installed. They are not supported by Evolution vanilla. Obtain the same effect by changing the base_uri file:/// to foo:/// in /apps/evolution/addressbook/sources

Stack trace:


Other information:
Comment 1 Øystein Gisnås 2007-04-24 20:25:03 UTC 
Created attachment 86940 [details] [review]
Fix for the GError resetting bug

Please apply this patch upstream although this crash is not the most common. It makes the error handling much more robust.
Comment 2 Bastien Nocera 2007-08-13 14:39:17 UTC 
*** Bug 441447 has been marked as a duplicate of this bug. ***
Comment 3 Bastien Nocera 2007-08-13 14:49:40 UTC 
Huh. Is the patch reversed?
Comment 4 Øystein Gisnås 2007-08-13 19:56:18 UTC 
Created attachment 93594 [details] [review]
Patch from Debian

There's certainly something fishy in that patch.. This is the one I successfully have used in Debian since April.
Comment 5 Bastien Nocera 2007-08-13 20:11:33 UTC 
Looks good, feel free to commit it.
Comment 6 Øystein Gisnås 2007-08-13 20:22:25 UTC 
Thanks. Was that for me to commit? I don't have commit rights..
Comment 7 Bastien Nocera 2007-08-13 20:25:26 UTC 
Doesn't apply. Could you update it against the current SVN? It seems to already be doing what it should...
Comment 8 Øystein Gisnås 2007-08-13 21:18:25 UTC 
Created attachment 93603 [details] [review]
Patch against trunk

Strange. Applies easily against trunk here.. Crossing fingers on both sides this time.
Comment 9 Bastien Nocera 2007-08-14 10:32:35 UTC 
Done, thanks.

2007-08-14  Bastien Nocera  <hadess@hadess.net>

        * src/plugins/evolution.c: (add_evolution_contacts_to_model):
        Patch from Oystein Gisnas <oystein@gisnas.net> to avoid
        crashes when an addressbook sources isn't supported
        (Closes: #433084)