After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 432714 - [Source List] Remove buttons
[Source List] Remove buttons
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: User interface
Git
Other Linux
: Normal normal
: 0.10.3
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2007-04-23 18:38 UTC by Edward Hervey
Modified: 2007-04-30 14:03 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Edward Hervey 2007-04-23 18:38:50 UTC
The buttons [Add/Remove] are completely out of place. There's already a button to add in the toolbar/menu and removing is available in the contextual menu.

REMOVE THEM !
Comment 1 Jean-François Fortin Tam 2007-04-25 13:49:48 UTC
There is a potential problem I see here. These buttons had the advantage of being "very clearly contextual"; you knew they governed the sources and only the sources.

Now that you would have add and remove buttons in the main toolbar, will they affect the timeline too? Clicking some clip in the timeline and using the remove button will remove it from the timeline, and clicking the same clip in the sources list will remove it from the sources and the timeline?

I'm not entirely sure about this, but I guess you must have thought about this already.
Comment 2 Edward Hervey 2007-04-25 15:08:01 UTC
They stick out in the middle of nowhere, they're clumsy. There's already an Add button in the toolbar.

As for removing an item, you can remove it using the contextual menu. There will not be a remove button in the toolbar.
Comment 3 Jean-François Fortin Tam 2007-04-25 18:21:41 UTC
What about one-button-mac-ubuntu-users? (okay, very few in numbers I know)

What about computer illiterate folks? a popup menu is NOT something that they would think of "out of sheer intuition". I know this from experience by training family members.

"Since the user may not be aware of their presence, do not provide functions that are only accessible from popup menus unless you are confident that your target users will know how to use popup menus." [...] "Popup menus are used primarily by intermediate and advanced users. Even some users who have used graphical desktops for many years do not know about popup menus until somebody shows them." (http://developer.gnome.org/projects/gup/hig/draft_hig_new/menus-types.html#menu-type-popup)

I can see the idea behind merging all toolbars into one, but then I believe having "contextual" actions is pretty intuitive too (although it may take more space). 

Furthermore, a disadvantage I see with putting everything into the main toolbar would be that you will end up with a toolbar with 20 items in it.

Anyway, the decision is yours I guess. IN ANY CASE, you *need* to make all the actions at least available from the top level menus. Do not leave them only hidden in a popup menu.
Comment 4 Edward Hervey 2007-04-30 14:03:46 UTC
2007-04-30  Edward Hervey  <edward@fluendo.com>

	* pitivi/discoverer.py:
	* pitivi/pixmaps/Makefile.am:
	* pitivi/pixmaps/busy.gif:
	* pitivi/sourcelist.py:
	* pitivi/ui/sourcefactories.py:
	Remove buttons in source list.
	The actions present in the toolbar and menu are enough, plus the fact
	that you can drop some files in it too.
	Add an indicator in the source list when importing is taking place.
	Much slicker than previous versions.
	Fixes #432714