After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 430787 - Disable eject if it isn't supported
Disable eject if it isn't supported
Status: RESOLVED FIXED
Product: sound-juicer
Classification: Applications
Component: general
2.14.x
Other Linux
: Normal enhancement
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
Depends on: 506930
Blocks:
 
 
Reported: 2007-04-17 20:21 UTC by Sven Arvidsson
Modified: 2008-02-14 08:53 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
Disable Eject menu item if ejection is not supported by the device (1.21 KB, patch)
2008-02-02 01:36 UTC, Dave Meikle 		committed Details | Review

Description Sven Arvidsson 2007-04-17 20:21:20 UTC 
[ Forwarded from http://bugs.debian.org/233134 ]

"My drive does not support the CDROMEJECT ioctl, so the Eject button and menu item always fail.  It would be better if they were disabled or removed in this case.

The CDROM_GET_CAPABILITIES ioctl can be used to determine whether eject is
supported."

There's a patch attached to the Debian bug, but I'm not sure if it's relevant as it's quite old.
Comment 1 Ross Burton 2008-01-02 21:22:54 UTC 
Sounds good to me, although it would be better if nautilus_burn_drive_can_eject() was added to libnautilus-burn.
Comment 2 Dave Meikle 2008-01-06 12:54:06 UTC 
I have written added the code for this to libnautilus-burn, and made the change to sound-juicer. How should I go about getting this added to libnautilus-burn? Raise an enhancement on that and refer back to this bug?
Comment 3 Ross Burton 2008-01-06 13:30:26 UTC 
I filed #506930, so you can attach a patch there.
Comment 4 Dave Meikle 2008-01-06 16:20:45 UTC 
Patch attached in #506930.
Comment 5 Dave Meikle 2008-01-21 07:20:56 UTC 
Now that nautilus_burn_drive_can_eject() has been added to nautilus-cd-burner, I will upload a patch for sound-juicer.
Comment 6 Dave Meikle 2008-02-02 01:36:55 UTC 
Created attachment 104236 [details] [review]
Disable Eject menu item if ejection is not supported by the device
Comment 7 Ross Burton 2008-02-14 08:53:17 UTC 
I added a configure time check for the new function (so I don't have to rebuild all of GNOME to test this!) and committed, thanks.