GNOME Bugzilla – Bug 430616
No indication of recording levels
Last modified: 2008-03-23 00:46:05 UTC
The bug has been opened on https://bugs.launchpad.net/ubuntu/+source/gnome-media/+bug/73369 "The Gnome sound recorder provides no indication of the levels of the sound that is being recorded, so knowing whether it is loud enough to be heard and whether it is so loud it will be distorted is a matter of trial, error, and guesswork. ..."
I would like this feature to. recording levels is a must. I use gnome-sound-recorder for recording lectures at college.
Would it be posible to use the gst interface to get data for the rec-level indicator? Could the data probing interface explained here: http://gstreamer.freedesktop.org/data/doc/gstreamer/head/manual/html/chapter-dataaccess.html be used ? The vumeter and pavumeter gets data from esd or pulseaudio. Unfortunately esd or pulseaudio are not always available.
Yeah, look at marlin for example code.
The issue is fixed. I added a the requested volume-meter to gnome-sound-recorder. After this change, a small volume-meter on the lower right-hand side of the application indicates recorded sound levels. The solution to the problem was to use the gstreamer plugin "level". The corresponding element then sends messages which are processed in a callback function. I will post the modified file grecord/src/gsr-window.c asap.
Created attachment 104374 [details] [review] source code including my changes Voila, here comes the code that I promised this morning. The attached file replaces grecord/src/gsr-window.c version 2.20.1. I you wish, I can provide you with a diff-file. I tested the file that I modified extensively, so I am confident it will work. Also, please feel free to contact me if you have further suggestions.
You would commonly provide a diff, I'd prefer that also.
Created attachment 104466 [details] [review] output of diff -u gsr-window.c gsr-window.c.modified No worries, here comes my diff. I hope this way you can apply my patch, so you can try the volume-meter that I added.
any changes this will get into 2.22 ? Is this ressource hungry? I like to preserve batteri time. Is it posible to en-/disable this on the fly?
It is not up to me to decide whether this will be implemented in 2.22. The change is not resource hungry but rather minimal. The sound level indicator is switched off after recording, so it should not really influence battery life.
(In reply to comment #9) > It is not up to me to decide whether this will be implemented in 2.22. > > The change is not resource hungry but rather minimal. The sound level indicator > is switched off after recording, so it should not really influence battery > life. > What do you mean by "switched off after recording"? Are there no level indicator during recording? I hope for this to get included in 2.22, as I plan to use Ubuntu Hardy when its released.
Yes, there is a sound level indicator during recording.
(In reply to comment #11) > Yes, there is a sound level indicator during recording. > Hi Tilman, Niiice! I am modifying your patch a bit, but I really liked it, it just worked for me :) I'll post an updated version. do you have a svn account?
Created attachment 107844 [details] [review] [1/1] 2008-03-23 Marc-Andre Lureau <marcandre.lureau@gmail.com> Initial patch by: Tilman Weiers * src/gsr-window.c (gsr_window_init, make_record_pipeline): Add recording level indication in the statusbar. (Closes: #430616) --- grecord/ChangeLog | 8 +++ grecord/src/gsr-window.c | 139 ++++++++++++++++++++++++++++++++++++++++------ 2 files changed, 130 insertions(+), 17 deletions(-)
Hi, I committed the latest patch. Your patch had several ~minor issues: - formatting (spaces, new-lines) - include <math.h> missing - weird table modifications, fixed size, - tiny level, not really fitting on the right, I moved it in the status bar instead - level element is not part of coreelements - "Level" is more appropriate than "Volume", I think - you touched the information table/labels without reasons, adding spaces - link_many is nicer than several links IMHO Thanks a lot anyway, I hope you'll continue!