After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 430249 - Remove Tag Icon
Remove Tag Icon
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Tags
0.2.1
Other All
: Normal enhancement
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2007-04-16 09:30 UTC by Juan Carlos Inostroza
Modified: 2007-09-25 10:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tag-icon-clear.patch (2.71 KB, patch)
2007-09-21 18:21 UTC, Maxxer
none Details | Review
tag-icon-clear.patch (2.71 KB, patch)
2007-09-21 22:20 UTC, Maxxer
none Details | Review
tag-icon-clear.patch (2.71 KB, patch)
2007-09-21 22:52 UTC, Maxxer
committed Details | Review

Description Juan Carlos Inostroza 2007-04-16 09:30:58 UTC
Well, just a way to delete the icon from a tag.
Comment 1 Stephane Delcroix 2007-06-11 13:45:52 UTC
hi Juan,

What's the use of removing a icon tag ?
Comment 2 Pedro Villavicencio 2007-06-20 03:36:12 UTC
just linking there's also a bug in launchpad about this https://bugs.launchpad.net/f-spot/+bug/118721
Comment 3 johnsong 2007-09-04 00:07:55 UTC
I agree that this would be a useful feature. I think the tag icons create unnecessary/unhelpful visual clutter, and so I have a lot of tags without icons. (This is only possible for parent tags with no photos which belong directly to the tags, at the moment.) Sometimes I accidentally set an icon for such a tag, and then the process to undo this is tedious. (I create a new tag, move all of the sub-tags to the new tag, delete the tag with the icon that I don't want, and then change the name of the new tag.)
Comment 4 Maxxer 2007-09-21 09:29:00 UTC
As discussed on #f-spot, there should be a "No image" button in the edit_icon_dialog dialog, like http://www.uni-koblenz.de/~monreal/abc/noimage.png

I hope I can work on this in the weekend (just in case someone else is doing this)!
Comment 5 Maxxer 2007-09-21 18:21:34 UTC
Created attachment 95977 [details] [review]
tag-icon-clear.patch

First try for the patch. Needs review! :)
I've used the standard stock icon "clear" for the button.

The button positioning isn't on the extreme left. If better placement is needed then someone with more knowledge of glade is also required. :)
Comment 6 Maxxer 2007-09-21 22:20:12 UTC
Created attachment 95993 [details] [review]
tag-icon-clear.patch

patch with "No image" instead of the stock icon "Clear". Should be fine now.
Comment 7 Maxxer 2007-09-21 22:52:44 UTC
Created attachment 95994 [details] [review]
tag-icon-clear.patch

wrong return code, pardon!
Comment 8 Maxxer 2007-09-23 19:18:33 UTC
Icons are automatically generated when attaching the tag to a (In reply to comment #3)
> I agree that this would be a useful feature. I think the tag icons create
> unnecessary/unhelpful visual clutter, and so I have a lot of tags without
> icons. (This is only possible for parent tags with no photos which belong
> directly to the tags, at the moment.) Sometimes I accidentally set an icon for
> such a tag, and then the process to undo this is tedious.

Following this comment, and the patch, maybe this behavior should be changed.

Maybe we should define a preference (or better a gconf key) which allows attaching tags without automatically creating the icon. 
Stephane, what do you think?
Comment 9 Stephane Delcroix 2007-09-25 10:24:42 UTC
fixed in r3401

(In reply to comment #8)

> Maybe we should define a preference (or better a gconf key) which allows
> attaching tags without automatically creating the icon. 
> Stephane, what do you think?

I'd say no.