GNOME Bugzilla – Bug 430228
[sunaudio] copyright bug
Last modified: 2007-04-17 01:58:23 UTC
The copyright info in sunaudio plugin code isn't quite right. It should include 2006 for all the plugins since we made many changes in 2006. Also in gstsunaudiosrc.c the plugin attributed Wim Taymans and Erik Walthinsen, which was a copy-paste error. They weren't involved with writing this code at all. Also remove David Schleef from gstsunaudiosrc.h - he wasn't involved with writing this plugin at all. He only wrote the original sink plugin. Note he wasn't ever mentioned in the gstsunaudiosrc.c file at all. Also clean up the comments at the top of each file so they are a bit more consistant.
Created attachment 86415 [details] [review] patch to clean up copyright info
Oh, also added Jan Schmidt to the gstsunaudiosrc.c plugin since he did a bunch of work to fix the code last December, 2006.
The gstsunaudiosrc.h chunk of the patch seems to have been a reverse patch? Committed to CVS with that chunk reversed: 2007-04-16 Tim-Philipp Müller <tim at centricular dot net> Patch by: Brian Cameron <brian.cameron at sun dot com> * sys/sunaudio/gstsunaudio.c: * sys/sunaudio/gstsunaudiomixer.c: * sys/sunaudio/gstsunaudiomixer.h: * sys/sunaudio/gstsunaudiomixerctrl.c: * sys/sunaudio/gstsunaudiomixerctrl.h: * sys/sunaudio/gstsunaudiomixertrack.h: * sys/sunaudio/gstsunaudiosink.c: * sys/sunaudio/gstsunaudiosink.h: * sys/sunaudio/gstsunaudiosrc.c: * sys/sunaudio/gstsunaudiosrc.h: Fix and/or update copyright attributions (#430228).
Yes, sorry the gstsunaudiosrc.h was a reverse patch. Thanks for fixing this.