After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 430031 - Documentation implies it's ok to change data from within a probe
Documentation implies it's ok to change data from within a probe
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: documentation
0.10.x
Other All
: Normal normal
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-04-15 16:35 UTC by follower
Modified: 2007-10-09 10:43 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description follower 2007-04-15 16:35:21 UTC
Documentation at http://gstreamer.freedesktop.org/data/doc/gstreamer/head/manual/html/chapter-dataaccess.html implies one could change data from within a probe--on IRC,Company says that's a bad idea.

> Company: 
> in principle it works, but...
> modifying buffers requires being the only one holding a reference to that buffer
> that's what copy_on_write does, it creates a copy if necessary
> unfortunately copying inside a probe callback does not work
> so what the example does is unsupported behaviour that works in that one example
Comment 1 Tim-Philipp Müller 2007-10-09 10:43:11 UTC
Quite right, thanks for the bug report. Should be clearer now:

  2007-10-09  Tim-Philipp Müller  <tim at centricular dot net>

        * docs/manual/advanced-dataaccess.xml:
          Don't imply that it's okay to unconditionally change
          buffer data or buffer metadata in a pad probe callback,
          and a bunch of other comments. Fixes #430031.