After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 429732 - gtk_accel_group_finalize accesses invalid memory
gtk_accel_group_finalize accesses invalid memory
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Class: UIManager / Actions
2.10.x
Other All
: Normal minor
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 386180
 
 
Reported: 2007-04-14 17:26 UTC by Armin Burgmeier
Modified: 2007-04-26 05:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1021 bytes, patch)
2007-04-14 17:27 UTC, Armin Burgmeier 		none Details | Review

Description Armin Burgmeier 2007-04-14 17:26:20 UTC 
There is a loop in gtk_accel_group_finalize that removes all accelerator entries. When there are two or more accelerators in the group, the code accesses invalid memory and does not actually release some of the entries.
Comment 1 Armin Burgmeier 2007-04-14 17:27:27 UTC 
Created attachment 86347 [details] [review]
Proposed patch

The fix is pretty obvious.
Comment 2 Matthias Clasen 2007-04-26 05:55:59 UTC 
2007-04-26  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkaccelgroup.c (gtk_accel_group_finalize): Don't access
        invalid memory.  (#429732, Armin Burgmeier)