After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 429329 - [videobox] add support for AYUV input
[videobox] add support for AYUV input
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal enhancement
: 0.10.6
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-04-13 12:19 UTC by Dejan Sakelšak
Modified: 2007-05-28 15:01 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
Adds AYUV support disabling transcoding I420 <-> AYUV (14.64 KB, patch)
2007-05-10 13:50 UTC, Dejan Sakelšak 		needs-work Details | Review
Patch adding AYUV->AYUV and AYUV->I420 (27.79 KB, patch)
2007-05-21 00:33 UTC, Dejan Sakelšak 		none Details | Review
Patch adding AYUV->AYUV and AYUV->I420 (27.79 KB, patch)
2007-05-21 07:13 UTC, Dejan Sakelšak 		committed Details | Review

Description Dejan Sakelšak 2007-04-13 12:19:53 UTC 
Support for fourcc AYUV format on sink of videobox plugin.
Comment 1 Dejan Sakelšak 2007-05-10 13:50:33 UTC 
Created attachment 87953 [details] [review]
Adds AYUV support disabling transcoding I420 <-> AYUV

Enables AYUV -> AYUV and I420 -> I420 to videobox and disables I420 -> AYUV transcoding.
Comment 2 Tim-Philipp Müller 2007-05-11 07:58:49 UTC 
As already pointed out on IRC:

 - please don't change indentation/style, that makes it harder to
   see the actual changes. There's ~/gstreamer/tools/gst-indent
   (which uses GNU indent) that you can run over your modified .c
   files (not the header files though please :))

 - you can't remove features in elements in -good. On-the-fly
   I420 => AYUV conversion is a feature of videobox.
Comment 3 Dejan Sakelšak 2007-05-21 00:33:46 UTC 
Created attachment 88524 [details] [review]
Patch adding AYUV->AYUV and AYUV->I420

Added:
- AYUV->AYUV conversion
- AYUV->I420 conversion
- caps problem fixed
Comment 4 Dejan Sakelšak 2007-05-21 07:13:17 UTC 
Created attachment 88530 [details] [review]
Patch adding AYUV->AYUV and AYUV->I420

Fixed U plane issue
Comment 5 Dejan Sakelšak 2007-05-21 10:47:19 UTC 
AYUV -> AYUV example:

gst-launch videotestsrc ! ffmpegcolorspace ! video/x-raw-yuv,format=\(fourcc\)AYUV ! videobox left=-30 right=21 top=-20 bottom=31 ! video/x-raw-yuv,format=\(fourcc\)AYUV ! ffmpegcolorspace ! autovideosink

AYUV -> I420 example:

gst-launch videotestsrc ! ffmpegcolorspace ! video/x-raw-yuv,format=\(fourcc\)AYUV ! videobox left=-30 right=21 top=-20 bottom=31 ! video/x-raw-yuv,format=\(fourcc\)I420 ! autovideosink

I420 -> I420 example:

gst-launch videotestsrc ! ffmpegcolorspace ! video/x-raw-yuv,format=\(fourcc\)I420 ! videobox left=-30 right=21 top=-20 bottom=31 ! video/x-raw-yuv,format=\(fourcc\)I420 ! autovideosink

I420 -> AYUV example:

gst-launch videotestsrc ! ffmpegcolorspace ! video/x-raw-yuv,format=\(fourcc\)I420 ! videobox left=-30 right=21 top=-20 bottom=31 ! video/x-raw-yuv,format=\(fourcc\)AYUV ! ffmpegcolorspace ! autovideosink
Comment 6 Wim Taymans 2007-05-28 15:01:53 UTC 
        Based on patch by: Dejan Sakelšak <sakdean at gmail dot com>

        * gst/videobox/gstvideobox.c: (gst_video_box_class_init),
        (gst_video_box_set_property), (gst_video_box_transform_caps),
        (video_box_recalc_transform), (gst_video_box_set_caps),
        (gst_video_box_get_unit_size), (gst_video_box_apply_alpha),
        (gst_video_box_ayuv_ayuv), (gst_video_box_clear), (UVfloor),
        (UVceil), (gst_video_box_ayuv_i420), (gst_video_box_i420_ayuv),
        (gst_video_box_i420_i420), (gst_video_box_transform),
        (plugin_init):
        Add AYUV->AYUV and AYUV->I420 formats.
        Fix negotiation and I420->AYUV conversion.
        Fixes #429329.