GNOME Bugzilla – Bug 429138
bad definition of structure _GyrusMainAppPrivate
Last modified: 2007-04-25 20:23:34 UTC
Please describe the problem: bad definition of structure _GyrusMainAppPrivate, not using suitably the structure. Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
Created attachment 86263 [details] [review] change structure definition.
Thanks for your patch! Patch looks fine, but there are other gobject classes in gyrus which may need similar cleaning up. Are you up to take care of them, too? The lines: + ///app->priv = g_new0 (GyrusMainAppPrivate, 1); + seem unnecesary to me. If that is not needed anymore, please remove it. Patch's changelog talks about changing the logo image. That's not related to this bug report. If interested on this, please clean up the patch. The best way to generate a good patch is by means of svn diff. Please use it for further patches. Thanks!
Created attachment 86264 [details] [review] clean patch replace patch.
Should I suposse this means you won't update the other classes?
Claudio... i'm working in this... patience :D
(In reply to comment #5) > Claudio... > > i'm working in this... patience :D > I plan to do a release of gyrus anytime soon, I'm just waiting for this patch to do it. If you can't work on it in the next days, please tell me, to do it myself.
(In reply to comment #6) > (In reply to comment #5) > > Claudio... > > > > i'm working in this... patience :D > > > > I plan to do a release of gyrus anytime soon, I'm just waiting for this patch > to do it. If you can't work on it in the next days, please tell me, to do it > myself. > ok, no problem... i am sorry... but now i have very much work.
Created attachment 86935 [details] [review] updated patch I commited this patch, which is based in yours. I attach it here in case you want to take a look at which other GObject facilities the GyrusMainApp class was lacking. I'll leave this bug open while I fix these issues in the GyrusAdmin class. Summary of the commit (rev. 264): 2007-04-24 Claudio Saavedra <csaavedra@alumnos.utalca.cl> * src/gyrus-main-app.c: (gyrus_main_app_finalize), (gyrus_main_app_destroy), (gyrus_main_app_class_init), (gyrus_main_app_init): Add the private structure definition here. Also improve the usage of the GObject facilities. * src/gyrus-main-app.h: Remove the definition of the private structure. Improve the usage of GObject facilities in the GyrusMainApp class. Based on a patch from Alejandro Valdes Jimenez <avaldes@utalca.cl>. Partially fixes bug #429138.
The following series of commits should have fixed all GObject related issues (r. 266, 269, 270, 271): 2007-04-25 Claudio Saavedra <csaavedra@alumnos.utalca.cl> * src/gyrus-dialog-mailbox-new.c: (gyrus_dialog_mailbox_new_class_init): * src/gyrus-dialog-mailbox-new.h: Clean GyrusDialogMailboxNew class. 2007-04-25 Claudio Saavedra <csaavedra@alumnos.utalca.cl> * src/gyrus-dialog-find-mailbox.c: (gyrus_dialog_find_mailbox_class_init), (gyrus_dialog_find_mailbox_finalize), (gyrus_dialog_find_mailbox_set_admin): * src/gyrus-dialog-find-mailbox.h: Clean GyrusDialogFindMailbox class. 2007-04-25 Claudio Saavedra <csaavedra@alumnos.utalca.cl> * src/gyrus-connection.c: (gyrus_connection_set_property), (gyrus_connection_class_init), (gyrus_connection_init): More GObject cleaning. This time, GyrusConnection. [...] 2007-04-24 Claudio Saavedra <csaavedra@alumnos.utalca.cl> * src/Makefile.am: Add gyrus-admin-private.h * src/gyrus-admin-mailbox.c: * src/gyrus-admin-private.h: New definition of the private data to hide it. * src/gyrus-admin.c: (gyrus_admin_class_init), (gyrus_admin_init), (gyrus_admin_finalize), (gyrus_admin_destroy): More GObject love. (+gyrus_admin_get_users_treeview): Added getter method. * src/gyrus-admin.h: Remove the private data declaration from here. * src/gyrus-dialog-find-mailbox.c: Use the getter instead of accessing to the private data directly. (gyrus_dialog_find_mailbox_on_button_find_clicked): Ditto. * src/gyrus-report.c: (gyrus_report_on_button_update_clicked): Ditto.