Created attachment 87157 [details] [review]
Normal a11y keynav on panels with arrow keys

Any review? Thanks.

While you're at it, there's a bug:

      if (event->keyval == GDK_Up || event->keyval == GDK_Down 
         ||event->keyval == GDK_Left)
        increment = ..;

GDK_Right should be in there also. Can you fix that? Other than that, I guess this is OK. It my even be simpler to just use if (!applet->pop) break; to prevent changing 100 lines of code (some projects care about that) just for an indentation change...

Created attachment 94633 [details] [review]
Normal a11y keynav on panels with arrow keys

Fixes additional problem mentioed by Ronald too.

Any opinions?

+      if (applet->pop {

...

Could you try to compile the patch? :-).

I like the fact that you can navigate, but also that you can change volume with the arrow keys without popping it. Here's what I would do: read orientation (applet->orientation) and allow only up/down if we're horizontal panel and left/right if we're vertical panel, that way we don't conflict with keynavigation. Then for that, just add a (if ((orient==hor&&(key==left||right)) || (orient==ver&&(key==up||down))) break;. That way we don't lose this functionality.

The recent reworking of the volume applet ensured that keyboard navigation works. This now counts as fixed.