After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 427586 - [PATCH] Seahorse attempts to chmod the daemon in the agent's Makefile
[PATCH] Seahorse attempts to chmod the daemon in the agent's Makefile
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
1.0.x
Other FreeBSD
: Normal normal
: 2.20.0
Assigned To: Seahorse Maintainer
Seahorse Maintainer
: 430223 435013 442754 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-04-08 14:11 UTC by Joe Marcus Clarke
Modified: 2007-06-01 02:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Removal of the chmod suid command in agent/Makefile.(in|am) (1.06 KB, patch)
2007-04-08 15:00 UTC, Dagmar d'Surreal 		rejected Details | Review

Description Joe Marcus Clarke 2007-04-08 14:11:14 UTC 
Seahorse 1.0.1 fails to install on a clean system since the agent's Makefile attempts to chmod the seahorse-daemon executable when it is not already installed.  This seems to be fallout from the daemon/agent split.  The trivial solution is to remove the install-exec-hook target from agent/Makefile.am.
Comment 1 Dagmar d'Surreal 2007-04-08 15:00:25 UTC 
Created attachment 86010 [details] [review]
Removal of the chmod suid command in agent/Makefile.(in|am)

This patch solved it here for building and installing into DESTDIR=/somewhere/new
Comment 2 Stef Walter 2007-04-08 15:18:50 UTC 
It should only try to do that on 'make install'. Is that the case for you?
Comment 3 Joe Marcus Clarke 2007-04-08 15:23:05 UTC 
Correct, make install on a clean system fails because the agent subdirectory is installed before the daemon subdirectory.  A reinstall on a system with seahorse already present will work.
Comment 4 Stef Walter 2007-04-08 18:13:42 UTC 
Oh, of course. Thanks for catching that. I don't know how that went unnoticed for this long :(

2007-04-07  Nate Nielsen  <nielsen@memberwebs.com>

    * agent/Makefile.am: Set proper binary as setuid. 
    Fixes bug #427586

Commit: 1721
Comment 5 Adam Schreiber 2007-04-16 11:11:10 UTC 
*** Bug 430223 has been marked as a duplicate of this bug. ***
Comment 6 Adam Schreiber 2007-05-02 01:16:56 UTC 
*** Bug 435013 has been marked as a duplicate of this bug. ***
Comment 7 Adam Schreiber 2007-06-01 02:31:46 UTC 
*** Bug 442754 has been marked as a duplicate of this bug. ***