After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 425464 - e-vcard optimisations
e-vcard optimisations
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
1.10.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2007-04-02 12:51 UTC by Ross Burton
Modified: 2007-04-03 07:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (2.83 KB, patch)
2007-04-02 12:51 UTC, Ross Burton 		none Details | Review
Revised patch (3.19 KB, patch)
2007-04-02 19:10 UTC, Ross Burton 		committed Details | Review

Description Ross Burton 2007-04-02 12:51:12 UTC 
I have some large optimisations that I need to carefully merge with upstream, but here are some simple ones to reduce the noise.

* Use g_list_prepend() and then reverse
* Use g_slice to allocate attribute and parameter structs, as there will be many of them.
Comment 1 Ross Burton 2007-04-02 12:51:24 UTC 
Created attachment 85699 [details] [review]
Patch
Comment 2 Srinivasa Ragavan 2007-04-02 18:59:10 UTC 
Ross, I will close this up tomorrow. But if you can give a diff with '-up' it is easy to review than this. I have to apply, diff locally and then review this.
Comment 3 Ross Burton 2007-04-02 19:10:35 UTC 
Created attachment 85719 [details] [review]
Revised patch

As requested.
Comment 4 Ross Burton 2007-04-02 19:11:17 UTC 
Oh and I recommend Meld for reviewing complex patches.  You can apply the patch to a checkout and it will graphically show you the changed.
Comment 5 Srinivasa Ragavan 2007-04-03 06:21:08 UTC 
Hey Ross, thanks I will try that for sure.
Comment 6 Srinivasa Ragavan 2007-04-03 07:33:19 UTC 
Hey looks fine for me to commit.
Comment 7 Ross Burton 2007-04-03 07:57:23 UTC 
Commited, thanks.