GNOME Bugzilla – Bug 425117
Misc iPod source patches
Last modified: 2007-06-07 20:07:23 UTC
Here are 2 patches which aren't making any functional changes to the iPod source, but which clean-up the code somehow. 1st one removes dead code and the 2nd one makes the code a bit cleaner imo, but it's totally subjective ;)
Created attachment 85645 [details] [review] Remove unused #ifdef
Created attachment 85646 [details] [review] Rework playlist handling
The second patch (and maybe the 1st one) won't apply without the patch from http://bugzilla.gnome.org/show_bug.cgi?id=424086#c12
I committed both of those patches (with slight changes so that they apply/compile)
2 more tiny patches for the iPod source.
Created attachment 86335 [details] [review] Use the new itdb_device_supports_artwork from libgpod This patch uses the new itdb_device_supports_artwork from libgpod to skip artwork processing altogether if the iPod can't display artwork. I realised when attaching this patch that a configure check for the new function is missing (though using HAVE_ITDB_TRACK_SET_THUMBNAILS_FROM_PIXBUF might be enough, it would only fail for people using a post libgpod 0.4.2 cvs checkout, but not up to date)
Created attachment 86336 [details] [review] Use itdb_get_mountpoint instead of having a priv->ipod_path var
Looks fine to me.
I committed the patch from comment #6 but not the one from comment #7 since I have some changes in progress that would conflict with that patch. Errr, and I noticed the "needs-work" status on the patch I committed after writing that comment :-/ I guess I'll clean that up when libgpod 0.5.0 is released.
Patch from comment #7 is obsolete with the landing of the async iTunesDB saving, marking it as such and marking that bug as fixed