After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 425006 - Add a note about the hooks in the AboutDialog
Add a note about the hooks in the AboutDialog
Status: RESOLVED FIXED
Product: gnome-perl
Classification: Bindings
Component: Gtk2
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk2-perl-bugs
gtk2-perl-bugs
Depends on: 425004
Blocks:
 
 
Reported: 2007-03-31 22:47 UTC by Emmanuele Bassi (:ebassi)
Modified: 2007-04-04 09:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch fixing the documentation (1.55 KB, patch)
2007-03-31 22:49 UTC, Emmanuele Bassi (:ebassi)
none Details | Review

Description Emmanuele Bassi (:ebassi) 2007-03-31 22:47:55 UTC
+++ This bug was initially created as a clone of Bug #425004 +++

[this is also a bug upstream, but the perl bindings should add a note too.]

the website and email links are made clickable only if the url and email hooks have been set before setting the 'website' and 'email' properties; if you set the hooks after that, the links won't be clickable.

the documentation should mention that the order is important, so a paragraph should be added, either in the main class description or in the hook setters function description:

'When setting the website and email hooks for the Gtk2::AboutDialog widget, you should remember that the order is important: you should set the hook functions before setting the website and email URL properties, like this:

  $about_dialog->set_url_hook(\&launch_web_browser);
  $about_dialog->set_website($app_website);

otherwise the AboutDialog widget will not display the website and the email addresses as clickable.'
Comment 1 Emmanuele Bassi (:ebassi) 2007-03-31 22:49:12 UTC
Created attachment 85632 [details] [review]
patch fixing the documentation
Comment 2 muppet 2007-04-01 01:34:50 UTC
Patch looks good to me.  Please commit.
Comment 3 Emmanuele Bassi (:ebassi) 2007-04-04 09:27:13 UTC
2007-04-04  Emmanuele Bassi  <ebassi@gnome.org>

        * xs/GtkAboutDialog.xs: Add a note about the order of the
        webmail and email properties and the url and email hook
        functions. (#425006)