GNOME Bugzilla – Bug 424328
Please remove shebangs from non-executable Python scripts
Last modified: 2008-01-05 23:56:02 UTC
Please describe the problem: Sabayon includes various non-executable Python scripts with shebangs. Debian has a patch to remove these (included below); would you consider merging it? diff -Naur admin-tool.orig/lockdown/disabledapplets.py admin-tool/lockdown/disabledapplets.py --- admin-tool.orig/lockdown/disabledapplets.py 2006-11-22 22:18:17.262365050 +0100 +++ admin-tool/lockdown/disabledapplets.py 2006-11-22 22:18:52.184547550 +0100 @@ -1,5 +1,3 @@ -#!/usr/bin/env python - # vim: set ts=4 sw=4 et: # diff -Naur admin-tool.orig/lockdown/globalvar.py admin-tool/lockdown/globalvar.py --- admin-tool.orig/lockdown/globalvar.py 2006-11-22 22:18:17.342370050 +0100 +++ admin-tool/lockdown/globalvar.py 2006-11-22 22:19:01.721143550 +0100 @@ -1,5 +1,3 @@ -#!/usr/bin/env python - # vim: set ts=4 sw=4 et: # diff -Naur admin-tool.orig/lockdown/icons.py admin-tool/lockdown/icons.py --- admin-tool.orig/lockdown/icons.py 2006-11-22 22:18:17.230363050 +0100 +++ admin-tool/lockdown/icons.py 2006-11-22 22:19:06.097417050 +0100 @@ -1,5 +1,3 @@ -#!/usr/bin/env python - # vim: set ts=4 sw=4 et: # diff -Naur admin-tool.orig/lockdown/lockdownapplier.py admin-tool/lockdown/lockdownapplier.py --- admin-tool.orig/lockdown/lockdownapplier.py 2006-11-22 22:18:17.230363050 +0100 +++ admin-tool/lockdown/lockdownapplier.py 2006-11-22 22:19:10.697704550 +0100 @@ -1,5 +1,3 @@ -#!/usr/bin/env python - # vim: set ts=4 sw=4 et: # diff -Naur admin-tool.orig/lockdown/lockdownbutton.py admin-tool/lockdown/lockdownbutton.py --- admin-tool.orig/lockdown/lockdownbutton.py 2006-11-22 22:18:17.310368050 +0100 +++ admin-tool/lockdown/lockdownbutton.py 2006-11-22 22:19:15.746020050 +0100 @@ -1,5 +1,3 @@ -#!/usr/bin/env python - # vim: set ts=4 sw=4 et: # diff -Naur admin-tool.orig/lockdown/lockdowncheckbutton.py admin-tool/lockdown/lockdowncheckbutton.py --- admin-tool.orig/lockdown/lockdowncheckbutton.py 2006-11-22 22:18:17.214362050 +0100 +++ admin-tool/lockdown/lockdowncheckbutton.py 2006-11-22 22:19:23.806523800 +0100 @@ -1,5 +1,3 @@ -#!/usr/bin/env python - # vim: set ts=4 sw=4 et: # diff -Naur admin-tool.orig/lockdown/maindialog.py admin-tool/lockdown/maindialog.py --- admin-tool.orig/lockdown/maindialog.py 2006-11-22 22:18:17.250364300 +0100 +++ admin-tool/lockdown/maindialog.py 2006-11-22 22:19:28.054789300 +0100 @@ -1,5 +1,3 @@ -#!/usr/bin/env python - # vim: set ts=4 sw=4 et: # diff -Naur admin-tool.orig/lockdown/safeprotocols.py admin-tool/lockdown/safeprotocols.py --- admin-tool.orig/lockdown/safeprotocols.py 2006-11-22 22:18:17.238363550 +0100 +++ admin-tool/lockdown/safeprotocols.py 2006-11-22 22:19:36.479315800 +0100 @@ -1,5 +1,3 @@ -#!/usr/bin/env python - # vim: set ts=4 sw=4 et: # diff -Naur admin-tool.orig/lockdown/simpleeditabletreeview.py admin-tool/lockdown/simpleeditabletreeview.py --- admin-tool.orig/lockdown/simpleeditabletreeview.py 2006-11-22 22:18:17.270365550 +0100 +++ admin-tool/lockdown/simpleeditabletreeview.py 2006-11-22 22:19:42.827712550 +0100 @@ -1,5 +1,3 @@ -#!/usr/bin/env python - # vim: set ts=4 sw=4 et: # Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Heh, most likely an error of cut&paste. Please commit with a suitable ChangeLog :)
Committed to pessulus. jrobeson committed to sabayon a few seconds before I did. :) Should admin-tool/lockdown/DONT_EDIT_FILES_HERE still exist? The sources in sabayon already seem to have diverged significantly from pessulus.
Shebang also removed from lockdowncombo.py, which did not exist in the original patch. On a related note, it looks like admin-tool/*.py should not have the executable bit set. OK to fix that as well?