After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 424328 - Please remove shebangs from non-executable Python scripts
Please remove shebangs from non-executable Python scripts
Status: VERIFIED FIXED
Product: sabayon
Classification: Deprecated
Component: general
2.18.x
Other All
: Normal trivial
: ---
Assigned To: Maintainers of sabayon
Maintainers of sabayon
Depends on:
Blocks:
 
 
Reported: 2007-03-30 00:34 UTC by Josh Triplett
Modified: 2008-01-05 23:56 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Josh Triplett 2007-03-30 00:34:14 UTC
Please describe the problem:
Sabayon includes various non-executable Python scripts with shebangs.  Debian has a patch to remove these (included below); would you consider merging it?

diff -Naur admin-tool.orig/lockdown/disabledapplets.py admin-tool/lockdown/disabledapplets.py
--- admin-tool.orig/lockdown/disabledapplets.py	2006-11-22 22:18:17.262365050 +0100
+++ admin-tool/lockdown/disabledapplets.py	2006-11-22 22:18:52.184547550 +0100
@@ -1,5 +1,3 @@
-#!/usr/bin/env python
-
 # vim: set ts=4 sw=4 et:
 
 #
diff -Naur admin-tool.orig/lockdown/globalvar.py admin-tool/lockdown/globalvar.py
--- admin-tool.orig/lockdown/globalvar.py	2006-11-22 22:18:17.342370050 +0100
+++ admin-tool/lockdown/globalvar.py	2006-11-22 22:19:01.721143550 +0100
@@ -1,5 +1,3 @@
-#!/usr/bin/env python
-
 # vim: set ts=4 sw=4 et:
 
 #
diff -Naur admin-tool.orig/lockdown/icons.py admin-tool/lockdown/icons.py
--- admin-tool.orig/lockdown/icons.py	2006-11-22 22:18:17.230363050 +0100
+++ admin-tool/lockdown/icons.py	2006-11-22 22:19:06.097417050 +0100
@@ -1,5 +1,3 @@
-#!/usr/bin/env python
-
 # vim: set ts=4 sw=4 et:
 
 #
diff -Naur admin-tool.orig/lockdown/lockdownapplier.py admin-tool/lockdown/lockdownapplier.py
--- admin-tool.orig/lockdown/lockdownapplier.py	2006-11-22 22:18:17.230363050 +0100
+++ admin-tool/lockdown/lockdownapplier.py	2006-11-22 22:19:10.697704550 +0100
@@ -1,5 +1,3 @@
-#!/usr/bin/env python
-
 # vim: set ts=4 sw=4 et:
 
 #
diff -Naur admin-tool.orig/lockdown/lockdownbutton.py admin-tool/lockdown/lockdownbutton.py
--- admin-tool.orig/lockdown/lockdownbutton.py	2006-11-22 22:18:17.310368050 +0100
+++ admin-tool/lockdown/lockdownbutton.py	2006-11-22 22:19:15.746020050 +0100
@@ -1,5 +1,3 @@
-#!/usr/bin/env python
-
 # vim: set ts=4 sw=4 et:
 
 #
diff -Naur admin-tool.orig/lockdown/lockdowncheckbutton.py admin-tool/lockdown/lockdowncheckbutton.py
--- admin-tool.orig/lockdown/lockdowncheckbutton.py	2006-11-22 22:18:17.214362050 +0100
+++ admin-tool/lockdown/lockdowncheckbutton.py	2006-11-22 22:19:23.806523800 +0100
@@ -1,5 +1,3 @@
-#!/usr/bin/env python
-
 # vim: set ts=4 sw=4 et:
 
 #
diff -Naur admin-tool.orig/lockdown/maindialog.py admin-tool/lockdown/maindialog.py
--- admin-tool.orig/lockdown/maindialog.py	2006-11-22 22:18:17.250364300 +0100
+++ admin-tool/lockdown/maindialog.py	2006-11-22 22:19:28.054789300 +0100
@@ -1,5 +1,3 @@
-#!/usr/bin/env python
-
 # vim: set ts=4 sw=4 et:
 
 #
diff -Naur admin-tool.orig/lockdown/safeprotocols.py admin-tool/lockdown/safeprotocols.py
--- admin-tool.orig/lockdown/safeprotocols.py	2006-11-22 22:18:17.238363550 +0100
+++ admin-tool/lockdown/safeprotocols.py	2006-11-22 22:19:36.479315800 +0100
@@ -1,5 +1,3 @@
-#!/usr/bin/env python
-
 # vim: set ts=4 sw=4 et:
 
 #
diff -Naur admin-tool.orig/lockdown/simpleeditabletreeview.py admin-tool/lockdown/simpleeditabletreeview.py
--- admin-tool.orig/lockdown/simpleeditabletreeview.py	2006-11-22 22:18:17.270365550 +0100
+++ admin-tool/lockdown/simpleeditabletreeview.py	2006-11-22 22:19:42.827712550 +0100
@@ -1,5 +1,3 @@
-#!/usr/bin/env python
-
 # vim: set ts=4 sw=4 et:
 
 #


Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Federico Mena Quintero 2008-01-04 22:37:22 UTC
Heh, most likely an error of cut&paste.  Please commit with a suitable ChangeLog :)
Comment 2 Josh Triplett 2008-01-05 23:46:08 UTC
Committed to pessulus.  jrobeson committed to sabayon a few seconds before I did. :)

Should admin-tool/lockdown/DONT_EDIT_FILES_HERE still exist?  The sources in sabayon already seem to have diverged significantly from pessulus.
Comment 3 Josh Triplett 2008-01-05 23:46:33 UTC
Committed to pessulus.  jrobeson committed to sabayon a few seconds before I did. :)

Should admin-tool/lockdown/DONT_EDIT_FILES_HERE still exist?  The sources in sabayon already seem to have diverged significantly from pessulus.
Comment 4 Josh Triplett 2008-01-05 23:56:02 UTC
Shebang also removed from lockdowncombo.py, which did not exist in the original patch.

On a related note, it looks like admin-tool/*.py should not have the executable bit set.  OK to fix that as well?