After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 424070 - [amrnbdec] add IF2 handling
[amrnbdec] add IF2 handling
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other Linux
: Normal enhancement
: 0.10.10
Assigned To: Sebastian Dröge (slomo)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-03-29 10:15 UTC by Benoit Fouet
Modified: 2008-11-05 11:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
diffs against r1.13 for amrnbdec.c (903 bytes, patch)
2007-03-29 10:16 UTC, Benoit Fouet
reviewed Details | Review

Description Benoit Fouet 2007-03-29 10:15:46 UTC
block size and mode are badly handled in case of AMR-NB IF2 format
Comment 1 Benoit Fouet 2007-03-29 10:16:55 UTC
Created attachment 85507 [details] [review]
diffs against r1.13 for amrnbdec.c
Comment 2 Tim-Philipp Müller 2007-05-07 17:50:52 UTC
Could you provide a little bit more background about this please?

Who would define IF2?

Looking at http://wiki.multimedia.cx/index.php?title=AMR-NB it seems more like those are two different bitstream variations (rather than a define set in the library).

If that is so, wouldn't it make more sense to have an amrnbdec and a amrnbdec-if2 or something, or set the right mode depending on the input caps?
Comment 3 Benoit Fouet 2007-05-09 07:05:23 UTC
your remark makes sense. it is indeed just a bitstream variation.
what i did was just to have the IF2 handling, without the IF1 one.
But it would be better to have both, yes.

FYI, the IF2 case is a common case for videotelephony on mobile phones for instance.
Comment 4 Sebastian Dröge (slomo) 2008-05-06 13:04:12 UTC
Ok, so is there a way to detect if IF2 or IF1 is used?
Comment 5 Benoit Fouet 2008-05-09 03:15:15 UTC
If your question is: is there a way to detect if from the decoder, then the answer is no.
Comment 6 Sebastian Dröge (slomo) 2008-05-09 07:04:50 UTC
Ok, so we should probably add a property for selecting the mode that defaults to the current mode... good.

So, is there something similar like these two modes for amrwb?
Comment 7 Benoit Fouet 2008-05-13 02:15:39 UTC
yes, there is the same thing for ARM-WB too.
you should refer to 3GPP TS 26.201 for the frame structures.
Comment 8 Wim Taymans 2008-11-05 11:03:18 UTC
        * ext/amrnb/amrnbdec.c: (gst_amrnb_variant_get_type),
        (gst_amrnbdec_class_init), (gst_amrnbdec_set_property),
        (gst_amrnbdec_get_property), (gst_amrnbdec_chain):
        * ext/amrnb/amrnbdec.h:
        Add a property to select the amr variant. Fixes #424070.