Bug 423992 – crash in Help: Clicked on the help butt...

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 423992 - crash in Help: Clicked on the help butt...


Summary:	crash in Help: Clicked on the help butt...


Status:	RESOLVED OBSOLETE

Product:	yelp
Classification:	Applications
Component:	General
Version:	2.18.x
Hardware:	Other All

Importance:	High critical
Target Milestone:	---
Assigned To:	Yelp maintainers
QA Contact:	Yelp maintainers

URL:
Whiteboard:

Duplicates:	452633 (view as bug list)
Depends on:
Blocks:

Reported:	2007-03-29 03:27 UTC by rcoffee
Modified:	2007-08-07 19:56 UTC

See Also:
GNOME target:	---
GNOME version:	2.17/2.18

Attachments
Proposed patch to fix crash in process_info_pending (1.30 KB, patch) 2007-05-14 08:07 UTC, Andreas Liebe	reviewed	Details \| Review

Description rcoffee 2007-03-29 03:27:18 UTC

Version: 2.18.0

What were you doing when the application crashed?
Clicked on the help button on Theme Preferences window


Distribution: Unknown
Gnome Release: 2.18.0 2007-03-15 (GNOME.Org)
BugBuddy Version: 2.18.0

System: Linux 2.6.19.1 #1 Mon Feb 26 18:49:57 EST 2007 i686
X Vendor: The X.Org Foundation
X Vendor Release: 70100000
Selinux: No
Accessibility: Enabled
GTK+ Theme: HighContrastInverse
Icon Theme: gnome

Memory status: size: 114163712 vsize: 114163712 resident: 69009408 share: 17059840 rss: 69009408 rss_rlim: 4294967295
CPU usage: start_time: 1175120750 rtime: 682 utime: 596 stime: 86 cutime:2 cstime: 1 timeout: 0 it_real_value: 0 frequency: 100

Backtrace was generated from '/usr/bin/yelp'

Using host libthread_db library "/lib/libthread_db.so.1".
[Thread debugging using libthread_db enabled]
[New Thread -1228544336 (LWP 20792)]
[New Thread -1269826640 (LWP 20795)]
[New Thread -1258890320 (LWP 20794)]
[New Thread -1248011344 (LWP 20793)]
0xb7f8a410 in __kernel_vsyscall ()

+ Trace 123108

Thread 1 (Thread -1228544336 (LWP 20792))

#0 __kernel_vsyscall
#1 ??
from /lib/libpthread.so.0
#2 libgnomeui_segv_handle
at gnome-ui-init.c line 872
#3 <signal handler called>
#4 strlen
from /lib/libc.so.6
#5 IA__g_strconcat
at gstrfuncs.c line 219
#6 process_info_pending
at yelp-toc-pager.c line 1632
#7 toc_process_pending
at yelp-toc-pager.c line 483
#8 g_idle_dispatch
at gmain.c line 3926
#9 IA__g_main_context_dispatch
at gmain.c line 2045
#10 g_main_context_iterate
at gmain.c line 2677
#11 IA__g_main_context_iteration
at gmain.c line 2736
#12 IA__gtk_main_iteration
at gtkmain.c line 1231
#13 xslt_yelp_document
at yelp-xslt-pager.c line 449
#14 xsltApplyOneTemplateInt
at transform.c line 2628
#15 xsltCallTemplate
at transform.c line 4188
#16 xsltApplyOneTemplateInt
at transform.c line 2525
#17 xsltForEach
at transform.c line 4944
#18 xsltApplyOneTemplateInt
at transform.c line 2525
#19 xsltIf
at transform.c line 4783
#20 xsltApplyOneTemplateInt
at transform.c line 2525
#21 xsltCallTemplate
at transform.c line 4188
#22 xsltApplyOneTemplateInt
at transform.c line 2525
#23 xsltIf
at transform.c line 4783
#24 xsltApplyOneTemplateInt
at transform.c line 2525
#25 xsltCallTemplate
at transform.c line 4188
#26 xsltApplyOneTemplateInt
at transform.c line 2525
#27 xsltForEach
at transform.c line 4944
#28 xsltApplyOneTemplateInt
at transform.c line 2525
#29 xsltIf
at transform.c line 4783
#30 xsltApplyOneTemplateInt
at transform.c line 2525
#31 xsltCallTemplate
at transform.c line 4188
#32 xsltApplyOneTemplateInt
at transform.c line 2525
#33 xsltIf
at transform.c line 4783
#34 xsltApplyOneTemplateInt
at transform.c line 2525
#35 xsltCallTemplate
at transform.c line 4188
#36 xsltApplyOneTemplateInt
at transform.c line 2525
#37 xsltChoose
at transform.c line 4656
#38 xsltApplyOneTemplateInt
at transform.c line 2525
#39 xsltApplyStylesheetInternal
at transform.c line 5338
#40 xslt_pager_process
at yelp-xslt-pager.c line 245
#41 process_cb
at yelp-pager.c line 268
#42 g_idle_dispatch
at gmain.c line 3926
#43 IA__g_main_context_dispatch
at gmain.c line 2045
#44 g_main_context_iterate
at gmain.c line 2677
#45 IA__g_main_loop_run
at gmain.c line 2881
#46 IA__gtk_main
at gtkmain.c line 1148
#47 main
at yelp-main.c line 121
#0 __kernel_vsyscall



----------- .xsession-errors (4836043 sec old) ---------------------
ESTART: 0.69281 [0.00003] - grabinput
ESTART: 0.69283 [0.00002] - modules
ESTART: 0.69286 [0.00002] - winlist
ESTART: 0.69288 [0.00002] - colorclasses
ESTART: 0.69291 [0.00003] - load modules
ESTART: 0.81884 [0.12594] - gadcon
ESTART: 0.81892 [0.00008] - shelves
ESTART: 0.81894 [0.00002] - exebuf
ESTART: 0.81897 [0.00003] - desklock
ESTART: 0.81913 [0.00016] - add idle enterers
ESTART: 0.81932 [0.00019] - init properites
ESTART: 0.83476 [0.01545] - test code
ESTART: 0.83482 [0.00006] - shelf config init
ESTART: 1.15668 [0.32186] - MAIN LOOP AT LAST
ESTART: 1.17773 [0.02105] - SLEEP
--------------------------------------------------

Comment 1 Andreas Liebe 2007-05-14 08:07:28 UTC

Created attachment 88145 [details] [review]
Proposed patch to fix crash in process_info_pending

This fixes crash inside process_info_pending by using the same index variable twice inside a loop.

Comment 2 Christian Kirbach 2007-07-01 13:01:57 UTC

good trace, confirming

Comment 3 Christian Kirbach 2007-07-01 13:02:15 UTC

*** Bug 452633 has been marked as a duplicate of this bug. ***

Comment 4 Christian Kirbach 2007-07-01 13:05:43 UTC

first frame has more details here

+ Trace 145051

#3 <signal handler called>
#4 strlen
from /lib/libc.so.6
#5 IA__g_strconcat
at gstrfuncs.c line 219
#6 process_info_pending
at yelp-toc-pager.c line 1632
#7 toc_process_pending
at yelp-toc-pager.c line 483
#8 g_idle_dispatch
at gmain.c line 3926

Comment 5 Christian Kirbach 2007-07-01 13:15:02 UTC

thanks for the patch Andreas.

from a very first glance:

* please attach the patch in the unified diff format (diff -u)
* seems to do no harm, but I haven't looked at the source

Comment 6 André Klapper 2007-07-22 12:53:39 UTC

Andreas, can you rework the patch as asked by Christian?

Comment 7 Don Scorgie 2007-08-07 19:56:53 UTC

in Yelp 2.19, this stuff has now been moved into Rarian.  This particular part of the TOC (if I can read non-unified diffs correctly) has been heavily altered and no longer suffers this problem.  If I'm wrong and you can reproduce with yelp 2.19.1 or later, please reopen / comment the bug and (if possible) provide a new / updated stack trace.  Thanks.