After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 423990 - glibmm et al don't recognize new GNU m4
glibmm et al don't recognize new GNU m4
Status: RESOLVED FIXED
Product: glibmm
Classification: Bindings
Component: build
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2007-03-29 03:14 UTC by Yaakov Selkowitz
Modified: 2008-07-23 13:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
scripts/macros.m4 GNU m4 patch (410 bytes, patch)
2007-04-20 03:56 UTC, Yaakov Selkowitz
none Details | Review
Use grep -i to check for GNU m4. Include ChangeLog entry. (895 bytes, patch)
2008-07-23 09:05 UTC, Damien Carbery
none Details | Review

Description Yaakov Selkowitz 2007-03-29 03:14:10 UTC
There was a change in the GNU m4 --version output in version 1.4.3.  scripts/macros.m4 expects "GNU m4 x.y.z" but current GNU m4 returns "GNU M4 x.y.z" -- the difference being the capitalized M in M4.  This causes AL_PROG_GNU_M4 to return no with the newer versions.

This affects scripts/macros.m4 in _ALL_ of the C++ bindings.
Comment 1 Murray Cumming 2007-04-02 08:50:37 UTC
Thanks. I wonder why I'm not having this problem on Ubuntu Feisty (with m4 1.4.8build1):
murrayc@murrayc-desktop:~$ m4 --version
GNU M4 1.4.8
Comment 2 Murray Cumming 2007-04-18 16:10:36 UTC
Anyway, a patch would be welcome.
Comment 3 Yaakov Selkowitz 2007-04-20 03:56:32 UTC
Created attachment 86674 [details] [review]
scripts/macros.m4 GNU m4 patch

> Thanks. I wonder why I'm not having this problem on Ubuntu Feisty (with m4
> 1.4.8build1):

"not having this problem" means that the result is yes or that the build still works?  AFAICS the test only does something on Solaris if not GNU m4.

In any case, patch attached.
Comment 4 Murray Cumming 2007-04-24 10:23:07 UTC
Committed to glibmm trunk (2.13) and glibmm-2-12 branch, and to gtkmm trunk (2.10), libglademm, gconfmm, gnome-vfsmm, libgnomecanvasmm, libgnomemm, libgnomeuimm, libgdamm, libgnomedbmm. Tell me if you need it on more branches or modules.

Thanks. Please don't forget the ChangeLog entry next time. I'll keep asking for it.
Comment 5 Yaakov Selkowitz 2007-04-24 12:01:06 UTC
gtksourceviewmm trunk.
Comment 6 Murray Cumming 2007-04-24 12:05:17 UTC
Done
Comment 7 Damien Carbery 2008-02-18 16:47:57 UTC
This patch is breaking the build for me on Solaris in 2.15.5 tarball.
The brackets in "[Mm]" are getting dropped when the code gets into 'configure'. 

My workaround has been to change:
grep '^GNU [Mm]4 '
to
grep -i '^GNU m4 '

Should I reopen this bug?
Comment 8 Damien Carbery 2008-07-21 15:07:55 UTC
Reopening as the bug still exists for me in 2.17.x.
Comment 9 Murray Cumming 2008-07-23 07:50:24 UTC
Could you submit an actual patch, please, ideally against svn, with a ChangeLog entry.
Comment 10 Damien Carbery 2008-07-23 09:05:24 UTC
Created attachment 115083 [details] [review]
Use grep -i to check for GNU m4. Include ChangeLog entry.
Comment 11 Murray Cumming 2008-07-23 13:12:08 UTC
Committed to svn trunk. Thanks.

I guess we will see if it stops working for anyone.