After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 423706 - Red-eye removal tool (RRT) does not work with people with darker skin
Red-eye removal tool (RRT) does not work with people with darker skin
Status: RESOLVED OBSOLETE
Product: gthumb
Classification: Other
Component: general
2.10.x
Other All
: Normal normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2007-03-28 12:41 UTC by Malte Cornils
Modified: 2015-12-18 17:45 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Malte Cornils 2007-03-28 12:41:02 UTC
Please describe the problem:
I was looking at the image on http://planck.djpig.de/~mcornils/rote-augen-kino-mar07.jpg
and tried to remove the man's eye reflection with gthumb's tool. Unfortunately, this discoloured large parts of his face. The tool worked well on the woman.

Steps to reproduce:
1. load the mentioned image in gthumb
2. click on the man's eyes
3. witness the algorithm spilling into parts of the face


Actual results:
The algorithm spills into parts of the face

Expected results:
Only the redness in the man's eyes is removed

Does this happen every time?
Yes

Other information:
Comment 1 Michael Chudobiak 2007-03-28 13:06:51 UTC
The current algorithm works well with "red eyes" that really are red. 

It does not work well with orange or white eyes, which can also occur in flash photos (as in the sample photo). 

Suggestions for improved algorithms are welcome... If you are aware of any open-source tools that do handle the sample photo correctly, let me know and perhaps we can use their algorithms.

- Mike
Comment 2 Michael Chudobiak 2007-03-28 13:16:15 UTC
Also reported at https://launchpad.net/ubuntu/+source/gthumb/+bug/85780.
Comment 3 Michael Chudobiak 2007-03-28 13:54:56 UTC
Hmm, I didn't read your original report carefully enough. Sorry! As you say, the current algorithm is seeing the skin as "red".

Maybe we can use this research: http://ivrgwww.epfl.ch/research/topics/red_eye_removal.html

- Mike
Comment 4 Malte Cornils 2007-03-29 00:40:57 UTC
Hmm, I used Digikam's (Qt-based application) Red eye tool - while it needs more user interaction (selecting the area of the eye), it works as advertised. If EFPL's algorithm is not helping, maybe an advanced option to draw a bounding rectangle over the eye area (or a circular "patch" with tunable diameter) will work.
Comment 5 Michael Chudobiak 2007-03-29 11:46:37 UTC
Flavien Volken (from EPFL) has sent me his thesis report and some sample code to study. If anyone else is interested in working on this, let me know, and I'll forward the stuff to you.

For now, I hope we can improve the algorithm and make the computer do the hard work, rather than requiring extra input from the user. I think we want gThumb to be an "easy to use" tool, rather than another gimp.

It will take a while to get it right...

- Mike
Comment 6 Michael Chudobiak 2007-07-16 15:51:38 UTC
Interesting library:

http://opencvlibrary.sourceforge.net/FaceDetection

I think you can feed the software sample of eyes/not-eyes, and it learns to classify them. (The example given is face detection, but I think it is more general than that).

- Mike
Comment 7 Michael Chudobiak 2015-12-18 17:45:26 UTC
Marking as obsolete, as the 2.x version are no longer supported.

Please feel free to reopen this bug report if it describes a problem that still occurs with a current version of gThumb (currently 3.4.1).