After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 423667 - Crash when searching
Crash when searching
Status: RESOLVED FIXED
Product: last-exit
Classification: Other
Component: general
unspecified
Other Linux
: Normal critical
: ---
Assigned To: Last-exit Maintainer(s)
Last-exit Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2007-03-28 10:35 UTC by Priit Laes (IRC: plaes)
Modified: 2007-04-08 16:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Changes 'match' node parsing Integer to Decimal (758 bytes, patch)
2007-04-07 23:58 UTC, Baris Cicek 		none Details | Review

Description Priit Laes (IRC: plaes) 2007-03-28 10:35:47 UTC 
Opened the "Find a station" box and tried to search for "Billy Idol"

Resulted in crash

amd@sl007 ~/code/gentoo/gnome/gnome-base/gnome-panel $ last-exit 
Starting new Last Exit server

Unhandled Exception: System.FormatException: Input string was not in the correct format
at System.Int32.Parse (string) <0x0004e>
at LastExit.FindStation.ParseSimilar (string) <0x00305>
at LastExit.FindStation.FindStationCompleted (LastExit.FMRequest) <0x000b2>
at (wrapper delegate-invoke) System.MulticastDelegate.invoke_void_FMRequest (LastExit.FMRequest) <0x0002a>
at LastExit.FMRequest.request_completed_idle () <0x0001a>
at (wrapper delegate-invoke) System.MulticastDelegate.invoke_bool () <0x0002c>
at IdleProxy.Handler () <0x0002a>
at (wrapper native-to-managed) IdleProxy.Handler () <0x00036>
in (unmanaged) 0xb7e99eb0
at (wrapper managed-to-native) Gtk.Application.gtk_main () <0x00004>
at Gtk.Application.Run () <0x00007>
at LastExit.Driver.Main (string[]) <0x00335>
Comment 1 Frederic Crozat 2007-03-31 14:48:25 UTC 
Confirming with a search on "Pat Metheny" with version 4 :

Unhandled Exception: System.FormatException: Input string was not in the correct format
at System.Int32.Parse (string) <0x0004e>
at LastExit.FindStation.ParseSimilar (string) <0x00305>
at LastExit.FindStation.FindStationCompleted (LastExit.FMRequest) <0x000b2>
at (wrapper delegate-invoke) System.MulticastDelegate.invoke_void_FMRequest (LastExit.FMRequest) <0x0002a>
at LastExit.FMRequest.request_completed_idle () <0x0001a>
at (wrapper delegate-invoke) System.MulticastDelegate.invoke_bool () <0x0002c>
at IdleProxy.Handler () <0x0002a>
at (wrapper native-to-managed) IdleProxy.Handler () <0x00036>
in (unmanaged) 0xb7eeeeaf
at (wrapper managed-to-native) Gtk.Application.gtk_main () <0x00004>
at Gtk.Application.Run () <0x00007>
at LastExit.Driver.Main (string[]) <0x00335>
Comment 2 DT 2007-04-07 11:11:51 UTC 
Confirming by searching in "Music that sounds like" on "Tori Amos" with version 4 on Ubuntu Feisty 7.04.

Unhandled Exception: System.FormatException: Input string was not in the correct format
at System.Int32.Parse (string) <0x0004e>
at LastExit.FindStation.ParseSimilar (string) <0x00305>
at LastExit.FindStation.FindStationCompleted (LastExit.FMRequest) <0x000b2>
at (wrapper delegate-invoke) System.MulticastDelegate.invoke_void_FMRequest (LastExit.FMRequest) <0x0002a>
at LastExit.FMRequest.request_completed_idle () <0x0001a>
at (wrapper delegate-invoke) System.MulticastDelegate.invoke_bool () <0x0002c>
at IdleProxy.Handler () <0x0002a>
at (wrapper native-to-managed) IdleProxy.Handler () <0x00036>
in (unmanaged) 0xb7e81090
at (wrapper managed-to-native) Gtk.Application.gtk_main () <0x00004>
at Gtk.Application.Run () <0x00007>
at LastExit.Driver.Main (string[]) <0x00335>
Comment 3 Baris Cicek 2007-04-07 23:58:26 UTC 
Created attachment 85970 [details] [review]
Changes 'match' node parsing Integer to Decimal

Problem is, search results might return decimal, so they should be handled with Decimal.Parse, instead of Int32.Parse. Then converted to Int32. This patch fixes crashes on those searches reported.
Comment 4 Brandon Hale 2007-04-08 10:16:31 UTC 
Checked in by Baris, fixes for me.
Thanks.
Comment 5 DT 2007-04-08 16:26:44 UTC 
Yes. The patch works also for me. Thanks a lot.