After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 423382 - Invalid UTF-8 in errors coming from gnupg
Invalid UTF-8 in errors coming from gnupg
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Mailer
1.10.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2007-03-27 16:20 UTC by Pascal Terjan
Modified: 2007-04-19 22:55 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
Convert messages to UTF-8 (3.91 KB, patch)
2007-03-27 16:21 UTC, Pascal Terjan
needs-work Details | Review
Convert messages to UTF-8 (1.01 KB, patch)
2007-04-08 17:04 UTC, Pascal Terjan
committed Details | Review

Description Pascal Terjan 2007-03-27 16:20:03 UTC
When using PGP encryption, if we are in a non UTF-8 locale, error dialogs are empty because of invalid UTF-8.
Comment 1 Pascal Terjan 2007-03-27 16:21:08 UTC
Created attachment 85393 [details] [review]
Convert messages to UTF-8
Comment 2 Jeffrey Stedfast 2007-03-27 23:08:49 UTC
patch looks good except it'd be better if it followed the coding guidelines...

- don't use gchar, use char
- don't use {}'s for 1-statement if/else's
- char *var, not char* var
- space before '(' of param lists

fix those issues and write up a ChangeLog entry and I'd say this patch was golden :)
Comment 3 Jeffrey Stedfast 2007-03-27 23:42:14 UTC
actually... why are you converting the diagnostics? they should already be in utf-8.
Comment 4 Pascal Terjan 2007-03-28 07:08:50 UTC
I first wrote the patch only on status because I get empty dialog when an error occur (with an invalid error UTF8 in the console). 
For the diagnostics I added this part to the patch as I could not find that they were in UTF-8 so I thought they had the same issue, I'll have an other look.
Comment 5 Pascal Terjan 2007-04-08 17:04:07 UTC
Created attachment 86016 [details] [review]
Convert messages to UTF-8

OK, I removed the part about diagnostics and used char * instead of gchar*
Comment 6 Jeffrey Stedfast 2007-04-08 19:35:55 UTC
looks good, thanks
Comment 7 Srinivasa Ragavan 2007-04-19 18:52:27 UTC
Updating bug status as per comment #6
Comment 8 Pascal Terjan 2007-04-19 22:55:43 UTC
Commited