After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 422956 - the STOP laptop hotkey is not captured by totem
the STOP laptop hotkey is not captured by totem
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
2.18.x
Other All
: Normal minor
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2007-03-26 11:19 UTC by Nicolò Chieffo
Modified: 2007-04-05 09:10 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
totem-stop-hotkey.diff (332 bytes, patch)
2007-03-26 11:20 UTC, Nicolò Chieffo
none Details | Review

Description Nicolò Chieffo 2007-03-26 11:19:38 UTC
Please describe the problem:
my laptop has 4 multimedia hotkeys:
previous, playpause, next (which works)
and stop (which does not work)

Every hotkey is configured under gnome keyboad shorcuts (and is working in rhythmbox)

Steps to reproduce:
1. open totem 
2. star a song/video
3. hit stop (configured in gnome keyboard shorcuts)


Actual results:
the song/video does not sop

Expected results:
that the song/video is stopped, the progress bar is brought to 0 and the totem screensaver is executed

Does this happen every time?
yes

Other information:
I've made a simple patch which I think can add this support. But something is missing: the GDK hotkey reference, but I don't know which is. maybe GDK_S?

http://librarian.launchpad.net/6938628/totem-stop-hotkey.diff
Comment 1 Nicolò Chieffo 2007-03-26 11:20:23 UTC
Created attachment 85313 [details] [review]
totem-stop-hotkey.diff
Comment 2 Bastien Nocera 2007-03-26 20:18:52 UTC
Thanks for the patch, but we don't really want to use stop...

Committed to gnome-2-18 and trunk

2007-03-26  Bastien Nocera  <hadess@hadess.net>

        * src/totem.c: (totem_action_handle_key_press): Make pause actually
        pause, and stop pause as well (Closes: #422956)
Comment 3 Nicolò Chieffo 2007-03-26 20:35:59 UTC
Why this strange decision?
Comment 4 Nicolò Chieffo 2007-04-05 08:49:58 UTC
the fix does not work in my case...
I've configured the stop hotkey in keyboard shorcuts and my stop value is

0xa4
Comment 5 Bastien Nocera 2007-04-05 09:05:30 UTC
Right, your patch wouldn't have worked either then...

Support was missing from the control-center media player code.

2007-04-05  Bastien Nocera  <hadess@hadess.net>

        * src/totem-remote.c: (on_media_player_key_pressed):
        Handle the "Stop" button as well (Closes: #422956)
Comment 6 Nicolò Chieffo 2007-04-05 09:10:02 UTC
I just had a try, sorry.