GNOME Bugzilla – Bug 422295
GstController crashes with quadratic and cubic interpolation modes
Last modified: 2007-06-08 20:45:07 UTC
Steps to reproduce: 1. Instantiate a GstController 2. Set up intervals and an interpolation mode of either GST_INTERPOLATE_CUBIC or GST_INTERPOLATE_QUADRATIC 3. Crash Stack trace: Seems like CUBIC and QUADRATIC are not implemented at all, and lead to an application crash, they are however documented (!) Other information:
Created attachment 85221 [details] Not a direct testcase, but this is the code we've encountered the problem within This is a simple crossfader (pass file 1 and file 2 as args to the app), in which it's made pretty obvious that the controller issue exists.
Yes, they're simply not implemented yet and this should be noted in the documentation IMHO. Implementing those modes is somewhere on my TODO list.
Can you fix the docs for the next core release to mention that those modes are not implemented and map both to the linear interpolation impl in the code? That way apps at least wouldn't crash heh. Or awesome would be if you could implement them for next core.
2007-05-04 Tim-Philipp Müller <tim at centricular dot net> * libs/gst/controller/gstcontroller.c: (gst_controlled_property_set_interpolation_mode): * libs/gst/controller/gstinterpolation.c: Don't crash if someone tries to set an interpolation mode that is invalid or that isn't supported yet. Fixes #422295. * tests/check/libs/controller.c: (GST_START_TEST), (gst_controller_suite): Add a test case for the above. 2007-05-04 Tim-Philipp Müller <tim at centricular dot net> * tests/check/Makefile.am: * tests/check/elements/volume.c: (GST_START_TEST), (volume_suite): Minimal check for volume's GstController usability; also another test for #422295.
Cubic interpolation was added in CVS some days ago.