GNOME Bugzilla – Bug 421342
Images over 5 MBs don't get thumbnails
Last modified: 2008-04-23 15:05:38 UTC
Please describe the problem: Nautilus currently does not generate thumbnails if the image is over 5 MBs of file size. Please increase the size limit to 10 MBs. My husband's Canon 5D 13 MP camera usually generates images between 4 and 7 MBs. I think that prosumer and professional photographers will have a problem with the current setting being too low. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Do you realize this is adjustable by the user? In any Nautilus window, Edit > Preferences > Preview lets you set the size threshold. - Mike
No, I don't realize that this is adjustable because I would never think that a modern application would have such a manual option there. Does it have to be adjustable? Just put the upper limit to 16 MBs and we are all cool. Digicams won't get bigger than 15 MP for a long time, it seems to be a sensor/technical limitation. Just like CPUs stopped racing the Mhz race, same for image sensors. This is why a 16 MB upper limit will be good enough for the next 10 years or so.
Created attachment 96194 [details] [review] Boost default thumbnail limit to 10 MB This patch boosts the default thumbnail limit to 10 MB, in both the schemas file and the fallback code. Also, it adds the "1 GB" entry to the enum. I don't understand why this enum isn't used to populate the limit widget. The widget is populated from another enum + the glade file labels. Why the duplication? Anyway, I have commit access if the review is OK... - Mike
More specifically we have: libnautilus-private/nautilus-global-preferences.c: static EelEnumerationEntry file_size_enum_entries[] = { { "102400", N_("100 K"), 102400 }, { "512000", N_("500 K"), 512000 }, { "1048576", N_("1 MB"), 1048576 }, { "3145728", N_("3 MB"), 3145728 }, { "5242880", N_("5 MB"), 5242880 }, { "10485760", N_("10 MB"), 10485760 }, { "104857600", N_("100 MB"), 104857600 }, { "1073741824", N_("1 GB"), 1073741824 }, { NULL } src/nautilus-file-management-properties.c: static const int thumbnail_limit_values[] = { 102400, 512000, 1048576, 3145728, 5242880, 10485760, 104857600, 1073741824, -1 src/nautilus-file-management-properties.glade: <property name="items" translatable="yes">100 KB 500 KB 1 MB 3 MB 5 MB 10 MB 100 MB 1 GB</property> Why the duplication? (The "1 GB" was missing in EelEnumerationEntry before my patch). - Mike
I would adjut it a little further.. i would give the user a few options to choose with the thumbnail limit. 2 below the current, 2 above and a custom one where the user can just pick a number and a type (kB, MB, GB). The list for the user in this case would be (my opinion) 1 MB 5 MB 10 MB (default) 15 MB 20 MB Custom (opens new dialog where the user can enter a number) For the question to boost the thumbnail limit to 10 MB.. I think it's a good idea. you got my vote for it.
Hi Michael, the patch itself looks good to me. Could you please bring this issue to the nautilus mailing list [1] for discussion? Thanks! [1] nautilus-list@gnome.org
Cosimo, I posted it as requested, but no one responded with any discussion. Can you or someone else approve as "ok to commit"? I have commit access... - Mike
Michael, I'm setting target 2.24 so this will be likely reviewed by someone during this development cycle.
Go for it, sorry for the delay.
Thanks, committed. - Mike