After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 420565 - gda_value_compare returns too early if value type is unknown
gda_value_compare returns too early if value type is unknown
Status: RESOLVED FIXED
Product: libgda
Classification: Other
Component: general
unspecified
Other Linux
: Normal trivial
: ---
Assigned To: Rodrigo Moya
gnome-db Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-03-20 15:16 UTC by Armin Burgmeier
Modified: 2007-03-26 18:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove the unnecessary line (1.09 KB, patch)
2007-03-20 15:17 UTC, Armin Burgmeier 		none Details | Review

Description Armin Burgmeier 2007-03-20 15:16:47 UTC 
There is a line that reads "return g_value_get_uint(value1) - g_value_get_uint(value2);" that is executed unconditionally if the type did not match one of the previous checks. According to the indentation, this seems to be a leftover of a previous change. It should be safe to remove it.
Comment 1 Armin Burgmeier 2007-03-20 15:17:27 UTC 
Created attachment 84979 [details] [review]
Remove the unnecessary line
Comment 2 Murray Cumming 2007-03-26 18:50:41 UTC 
Looks good. Pleae commit.
Comment 3 Armin Burgmeier 2007-03-26 18:58:28 UTC 
Done.