After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 420326 - Base payloader class has wrong property types and ranges
Base payloader class has wrong property types and ranges
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 0.10.14
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-03-19 22:25 UTC by Philippe Khalaf
Modified: 2007-07-14 17:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix types and ranges of some properties (4.83 KB, patch)
2007-03-19 22:27 UTC, Philippe Khalaf 		rejected Details | Review

Description Philippe Khalaf 2007-03-19 22:25:16 UTC 
* Timestamp offset is an int with a max of G_MAXINT32, it should be a gint64 with a max of G_MAXUINT32 (because it can be set to -1).

* Seqnum offset is an int16 with a max of G_MAXINT, it should be a gint32 with a max of G_UINT16 (because it can be set to -1).

* Seqnum has a max of G_MAXINT, it should be G_MAXUINT16.

patch attached
Comment 1 Philippe Khalaf 2007-03-19 22:27:55 UTC 
Created attachment 84921 [details] [review]
Fix types and ranges of some properties
Comment 2 Wim Taymans 2007-03-20 11:08:12 UTC 
this will break ABI. You can probably do something with extra gbooleans at the end of the struct to mark the fields as 'unset'.
Comment 3 Wim Taymans 2007-07-14 17:23:55 UTC 
        * gst-libs/gst/rtp/gstbasertppayload.c:
        (gst_basertppayload_class_init), (gst_basertppayload_init),
        (gst_basertppayload_event), (gst_basertppayload_push),
        (gst_basertppayload_set_property),
        (gst_basertppayload_get_property),
        (gst_basertppayload_change_state):
        * gst-libs/gst/rtp/gstbasertppayload.h:
        Fix ranges of rtp payloader properties so that the full range can be
        used in addition to -1 (random).
        Fix wrong seqnum reporting in caps.
        Fixes #420326.