After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 420306 - libgda GnomeGoals/PoptGOption
libgda GnomeGoals/PoptGOption
Status: RESOLVED FIXED
Product: libgda
Classification: Other
Component: Tools
unspecified
Other All
: Normal enhancement
: ---
Assigned To: Rodrigo Moya
gnome-db Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-03-19 21:29 UTC by Yaakov Selkowitz
Modified: 2007-03-27 13:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
This patch makes libgda-config-tool to use GOption (5.83 KB, patch)
2007-03-26 00:29 UTC, Baris Cicek 		none Details | Review
GOption changes with autotools file fixes (7.80 KB, patch)
2007-03-27 11:15 UTC, Baris Cicek 		none Details | Review

Description Yaakov Selkowitz 2007-03-19 21:29:54 UTC 
http://live.gnome.org/GnomeGoals/PoptGOption

popt is used only in tools/gda-config-tool.c; this should be ported to GOption.

tools/gda-run.c #include <popt.h> but doesn't use it; it uses a simple usage message instead.  Should it use GOption as well?

This can be done post-3.0.
Comment 1 Baris Cicek 2007-03-26 00:29:03 UTC 
Created attachment 85282 [details] [review]
This patch makes libgda-config-tool to use GOption

As it's stated in GNOME Goals, this patch is using GOption to show --help and option parsing. Also fixed some compile warnings. 

Referance to Gnome Goals:
http://live.gnome.org/GnomeGoals/PoptGOption
Comment 2 Baris Cicek 2007-03-26 00:32:17 UTC 
gda-run.c does not even run usage function, neither it support those arguments. It must be a stub code.
Comment 3 Yaakov Selkowitz 2007-03-26 01:34:11 UTC 
Thank you for the patch.  You need to remove the popt detection from configure.in as well, as it is no longer needed.
Comment 4 Murray Cumming 2007-03-26 18:54:22 UTC 
And then, feel free to commit. Thanks.
Comment 5 Yaakov Selkowitz 2007-03-26 19:09:33 UTC 
Don't forget to remove POPT_LIB from gda_config_tool_3_0_LDADD in tools/Makefile.am as well.
Comment 6 Baris Cicek 2007-03-27 11:15:44 UTC 
Created attachment 85379 [details] [review]
GOption changes with autotools file fixes

Autotools stuff is not my forte. I could not compile svn due to my build environment. If someone checks the changes I made, I can commit this patch. 

I've also saved gda-run.c from popt.h, which is not used anyways.
Comment 7 Baris Cicek 2007-03-27 11:40:00 UTC 
I found what's wrong about configure.in. Fixed it and commited. Since I could build, I belive I did not broke anything.
Comment 8 Murray Cumming 2007-03-27 13:11:02 UTC 
Thanks, Baris.