After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 420173 - Escape becomes bound to exiting learn mode
Escape becomes bound to exiting learn mode
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
unspecified
Other All
: Normal major
: ---
Assigned To: Orca Maintainers
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-03-19 16:30 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2007-03-19 19:36 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
proposed patch (500 bytes, patch)
2007-03-19 17:20 UTC, Joanmarie Diggs (IRC: joanie)
none Details | Review
Alternative patch - reverting the code back to what it was before the "for refactoring". (1.12 KB, patch)
2007-03-19 19:36 UTC, Rich Burridge
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2007-03-19 16:30:23 UTC
Steps to reproduce:

1. Launch Orca
2. Launch Gedit
3. Enter learn mode and press Escape
4. Press Control O for Gedit's Open dialog
5. Press Escape to close the Open dialog

Actual results: Orca says "Exiting learn mode" and the dialog box does not close

Expected results: Orca wouldn't say "Exiting learn mode" and the dialog box would close.
Comment 1 Joanmarie Diggs (IRC: joanie) 2007-03-19 17:08:04 UTC
This was the result of the for statement refactoring (bug #402494).

In keybindings.py, KeyBindings' remove method now looks like this:

        for item in self.keyBindings:
            if keyBinding == item:
                del item

It used to look like this:

        for i in range(0, len(self.keyBindings)):
            if keyBinding == self.keyBindings[i]:
                del self.keyBindings[i]

I'm guessing that to delete an item from a list, you have to specify that item by listName[indexOfItem]

Comment 2 Joanmarie Diggs (IRC: joanie) 2007-03-19 17:20:26 UTC
Created attachment 84893 [details] [review]
proposed patch
Comment 3 Rich Burridge 2007-03-19 17:30:49 UTC
Actually, I suggest just putting it back the way it was:

        for i in range(0, len(self.keyBindings)):
            if keyBinding == self.keyBindings[i]:
                del self.keyBindings[i]

This was another of those cases, where I should have left it alone...
Comment 4 Rich Burridge 2007-03-19 19:36:29 UTC
Created attachment 84908 [details] [review]
Alternative patch - reverting the code back to what it was before the "for refactoring".

I've checked the patch in. I'm going to close the bug as fixed.
Will/Mike, we probably want to either apply this patch to the
systems at CSUN (if we are using a version of Orca from SVN trunk/HEAD).
Adding that comment here so that we don't forget.