After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 420133 - gst_element_sync_state_with_parent should look at pending state too
gst_element_sync_state_with_parent should look at pending state too
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.13
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-03-19 15:03 UTC by Olivier Crête
Modified: 2007-03-20 09:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sync with pending state if any (818 bytes, patch)
2007-03-19 15:05 UTC, Olivier Crête 		committed Details | Review

Description Olivier Crête 2007-03-19 15:03:45 UTC 
I'm attaching a very simple patch that makes gst_element_sync_with_parent sync with the pending state of the parent if its not NULL_PENDING.
Comment 1 Olivier Crête 2007-03-19 15:05:09 UTC 
Created attachment 84878 [details] [review]
sync with pending state if any

Also, this patch is racy (since the state can change between unlocking the object here and relocking it set_state, but it seems there is nothing we can do without recursive locks).
Comment 2 Wim Taymans 2007-03-20 09:45:52 UTC 
        Patch by: Olivier Crete <tester at tester dot ca>

        * gst/gstelement.c: (gst_element_sync_state_with_parent):
        Look at the pending state too when syncing the element state to the
        parent. Fixes #420133.