After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 419927 - calculator rcl function does not work as documented
calculator rcl function does not work as documented
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
5.9.x
Other All
: Normal normal
: ---
Assigned To: Sami Pietilä
Rich Burridge
Depends on:
Blocks:
 
 
Reported: 2007-03-18 22:53 UTC by Sebastien Bacher
Modified: 2007-04-30 15:22 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
Patch from Sami. (2.14 KB, patch)
2007-04-04 21:29 UTC, Rich Burridge
needs-work Details | Review
New version of the patch from Sami. (2.58 KB, patch)
2007-04-30 15:06 UTC, Rich Burridge
committed Details | Review

Description Sebastien Bacher 2007-03-18 22:53:14 UTC
The bug has been opened on https://launchpad.net/bugs/92863

"Applications
    Calculator
         Select any calculator except the most basic one.
         Put a number in the display field ( i.e. 33)
         Press STO key, select R5 and save.
         Clear the display field.
         Press RCL key, select R5.
         Display shows "R5", instead of "33".
..."
Comment 1 Rich Burridge 2007-03-18 23:59:50 UTC
You can then hit Return to calculate the answer, and you get 
what's in R5 (i.e. 33).

I'd prefer it automatically convert from R<n> to the contents
of R<n> when you do the actual Rcl, so as this problem is only in
"Arithmetic Precedence" mode, assigning to Sami so he can fix it.

Comment 2 Rich Burridge 2007-04-04 21:29:48 UTC
Created attachment 85827 [details] [review]
Patch from Sami.

To be tested...
Comment 3 Rich Burridge 2007-04-23 14:44:42 UTC
On closer investigation there are two minor problems with this patch:

1/ Use of tabs for indentation. The unit of indentation within 
   gcalctool code is 4 spaces.

2/ Declaration of variables need to be at the top of a code block 
   in order to properly compile with older versions of the gcc 
   compiler.

I've asked Sami to rework the patch and resubmit it.
Comment 4 Rich Burridge 2007-04-30 15:06:33 UTC
Created attachment 87273 [details] [review]
New version of the patch from Sami.
Comment 5 Rich Burridge 2007-04-30 15:22:13 UTC
Patched committed. Changes in SVN HEAD/trunk
Closing as FIXED. Thanks.