After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 419851 - pad-added and pad-removed signals parameter type incorrect
pad-added and pad-removed signals parameter type incorrect
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal minor
: 0.10.13
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-03-18 19:22 UTC by Evan Nemerson
Modified: 2007-03-19 12:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix (1.12 KB, patch)
2007-03-18 19:22 UTC, Evan Nemerson 		committed Details | Review

Description Evan Nemerson 2007-03-18 19:22:06 UTC 
I'm working on bindings for PHP and ran across a small problem with the
pad-added and pad-removed signals. Basically, they pass their parameters
as G_TYPE_OBJECT instead of GST_TYPE_PAD.
Comment 1 Evan Nemerson 2007-03-18 19:22:47 UTC 
Created attachment 84843 [details] [review]
fix
Comment 2 Edward Hervey 2007-03-18 20:26:16 UTC 
The fix is correct but the problem is whether this fix is considered as breaking API or not.

If it is, it will have to go in 0.11, else it can be commited.
Comment 3 Wim Taymans 2007-03-19 09:26:47 UTC 
The function prototype in the GstElementClass already has GstPad as an arg. 

I can't think of code that would meaningfully fail if the callback would be changed to a GstPad (which is also a GObject) moreso because the object in the callback has always _been_ a GstPad.
Comment 4 Tim-Philipp Müller 2007-03-19 11:47:47 UTC 
Don't see any reason not to commit that either.
Comment 5 Wim Taymans 2007-03-19 12:07:46 UTC 
        Patch by: Evan Nemerson <evan at coeus dash group dot com>

        * gst/gstelement.c: (gst_element_class_init):
        Fix pad-added and pad-removed signal signatures so that the pad type is
        stated as GST_TYPE_PAD instead of G_TYPE_OBJECT. Fixes #419851.