After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 419642 - esound does not compile with --enable-debugging
esound does not compile with --enable-debugging
Status: RESOLVED FIXED
Product: esound
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Esound Maintainers
Esound Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-03-18 08:26 UTC by Jean Bréfort
Modified: 2007-03-19 22:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed fix (469 bytes, patch)
2007-03-18 08:27 UTC, Jean Bréfort 		none Details | Review
Better fix. (846 bytes, patch)
2007-03-19 18:51 UTC, Daniel Gryniewicz 		committed Details | Review

Description Jean Bréfort 2007-03-18 08:26:00 UTC 
The compilation fails in players.c, line 309:players.c, at least with gcc-4.1.2:
In function ‘read_player’:
players.c:309: erreur: expected expression before ‘do’
Comment 1 Jean Bréfort 2007-03-18 08:27:41 UTC 
Created attachment 84817 [details] [review]
proposed fix
Comment 2 Daniel Gryniewicz 2007-03-19 18:51:26 UTC 
Created attachment 84905 [details] [review]
Better fix.

No, that will break the do/while wrapper, meaning it cannot be called after an if statement without braces.  The problem is the caller expecting a value to be returned; it's not, it's an argument.  I believe this is the correct fix.
Comment 3 David Schleef 2007-03-19 22:24:26 UTC 
Applied, thanks.