After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 419474 - Window much too wide when using Jamendo/Magnatune plugin
Window much too wide when using Jamendo/Magnatune plugin
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
0.9.8
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 432754 449812 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-03-17 19:35 UTC by Sven Arvidsson
Modified: 2007-06-21 22:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rhythmbox-0.10--shops-resizing.patch (39.98 KB, patch)
2007-05-08 16:00 UTC, Bastien Nocera
committed Details | Review
rhythmbox-trunk--shops-resizing.patch (92.87 KB, patch)
2007-05-08 16:01 UTC, Bastien Nocera
committed Details | Review

Description Sven Arvidsson 2007-03-17 19:35:30 UTC
This is Debian bug 415215.
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=415215

One Debian user reported that Rhythmbox resizes the window as soon as the Jamendo view is clicked. The width is increased to something between 1400 and 1600px. Rhythmbox is running maximised in 1280x1024 when this happens.

Debug output,
(19:42:31) [0x80f2030] [source_selected_cb] rb-shell.c:1696: source selected
(19:42:31) [0x80f2030] [rb_shell_select_source] rb-shell.c:2021: selecting source 0x86588d8
(19:42:31) [0x80f2030] [rb_plugin_find_file] rb-plugin.c:255: found '/usr/lib/rhythmbox/plugins/jamendo/jamendo-loading.glade' when searching for file 'jamendo-loading.glade' for plugin 'jamendo'
(19:42:31) [0x80f2030] [rb_shell_clipboard_set_source_internal] rb-shell-clipboard.c:350: selected source 0x86588d8
(19:42:31) [0x80f2030] [rb_shell_clipboard_sync] rb-shell-clipboard.c:549: syncing clipboard
(19:42:31) [0x80f2030] [rebuild_playlist_menu] rb-shell-clipboard.c:1018: rebuilding add-to-playlist menu
(19:42:31) [0x80f2030] [rb_shell_player_set_source_internal] rb-shell-player.c:754: selected source 0x86588d8
(19:42:31) [0x80f2030] [rb_shell_player_sync_with_selected_source] rb-shell-player.c:2738: syncing with selected source: 0x86588d8
(19:42:31) [0x80f2030] [rb_shell_player_sync_with_selected_source] rb-shell-player.c:2741: no playing source, new source is 0x86588d8
(19:42:31) [0x80f2030] [rb_shell_player_sync_with_source] rb-shell-player.c:2358: playing source: (nil), active entry: (nil)
(19:42:31) [0x80f2030] [rb_shell_set_window_title] rb-shell.c:2125: clearing title
(19:42:31) [0x80f2030] [rb_shell_player_get_playing_song_duration] rb-shell-player.c:2724: Did not get playing entry : return -1 as length
(19:42:31) [0x80f2030] [show_controls] rb-visualizer-plugin.c:548: showing controls
(19:42:31) [0x80f2030] [rb_shell_player_get_playing_song_duration] rb-shell-player.c:2724: Did not get playing entry : return -1 as length
(19:42:31) [0x80f2030] [rb_header_sync] rb-header.c:355: syncing with entry = (nil)
(19:42:31) [0x80f2030] [rb_header_sync] rb-header.c:426: not playing
(19:42:31) [0x80f2030] [rb_shell_player_sync_buttons] rb-shell-player.c:2461: syncing with source 0x86588d8
(19:42:31) [0x80f2030] [rb_source_header_set_source_internal] rb-source-header.c:318: selected source 0x86588d8
(19:42:31) [0x80f2030] [rb_statusbar_set_property] rb-statusbar.c:313: selected source 0x86588d8
(19:42:31) [0x80f2030] [rb_statusbar_sync_status] rb-statusbar.c:417: updating status with: 'Chargement du catalogue Jamendo', '', -1,000000
(19:42:31) [0x80f2030] [shell_selected_source_notify_cb] rb-cd-recorder-plugin.c:302: RBCdRecorderPlugin selected source changed
(19:42:31) [0x80f2030] [rb_statusbar_source_status_changed_cb] rb-statusbar.c:505: source status changed
(19:42:31) [0x80f2030] [rb_shell_window_configure_cb] rb-shell.c:1609: storing window size of 1469:775
Comment 1 Bastien Nocera 2007-04-18 22:47:07 UTC
The same problem exists on the 0.10 branch, but the page gets truncated on both sides in the trunk version.
Comment 2 Christophe Fergeau 2007-04-23 21:16:41 UTC
*** Bug 432754 has been marked as a duplicate of this bug. ***
Comment 3 Jean-François Fortin Tam 2007-04-25 18:42:58 UTC
Why is this happening actually? Because the splash page's text is not wrapped or something?

This prevents me from using RB + jamendo/magnatune on a 1024x768 screen.
Comment 4 Jonathan Matthew 2007-04-25 22:46:01 UTC
Yes.  Simply enabling text wrapping makes it look terrible on any screen, though.
Comment 5 Jean-François Fortin Tam 2007-04-26 00:12:50 UTC
better ugly than bumping up the window size imho.

However I feel this is putting a band-aid on the underlying problem; why in the world do these splash pages have SO MUCH text? I think it would be much better to put a really short summary with a "show me more info" button that displays a new window with a scrolling text field, and a "show me the website" for a full-length feature list.
I don't know if this could even be considered, but I, personally, could cut the width and height of that text by half just by removing some irrelevant bits (considering rhythmbox integration), rephrasing, and, generally, just sticking to a "very important features of this music store" thing instead of "add as much bullet points as possible to make it look like there are more actual reasons to do business with us".

I feel I may be unclear in the way I tried to express my thoughts, don't be mistaken I am not angry at magnatune/jamendo, I just feel that the "executive propaganda" could be toned down a bit by having the text simplified a LOT.

And why are the logos so gigantic? The magnatune logo eats 1/3 of the width and the jamendo logo uses ½ of the height! o_o
Comment 6 Bastien Nocera 2007-05-08 16:00:08 UTC
Created attachment 87815 [details] [review]
rhythmbox-0.10--shops-resizing.patch

Just put the loading screen in a scrolledwindow and viewport. Better than the alternatives.
Comment 7 Bastien Nocera 2007-05-08 16:01:06 UTC
Created attachment 87816 [details] [review]
rhythmbox-trunk--shops-resizing.patch

Same one for trunk
Comment 8 Luis Menina 2007-06-06 13:16:25 UTC
Could this be reviewed ?
It's indeed an annoying problem... Minimize/maximize and close buttons disappear from screen.
Comment 9 James "Doc" Livingston 2007-06-06 13:36:29 UTC
Patches committed to svn stable and trunk, thanks.
Comment 10 Jonathan Matthew 2007-06-21 22:04:33 UTC
*** Bug 449812 has been marked as a duplicate of this bug. ***